* [PATCH v1] perf report: Skip unsupported new event types
@ 2025-03-28 23:01 Chun-Tse Shao
2025-03-29 0:39 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Chun-Tse Shao @ 2025-03-28 23:01 UTC (permalink / raw)
To: linux-kernel
Cc: Chun-Tse Shao, Arnaldo Carvalho de Melo, Namhyung Kim, peterz,
mingo, mark.rutland, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, dvyukov, ben.gainey, linux-perf-users
`perf report` currently halts with an error when encountering
unsupported new event types (`event.type >= PERF_RECORD_HEADER_MAX`).
This patch modifies the behavior to skip these samples and continue
processing the remaining events.
Signed-off-by: Chun-Tse Shao <ctshao@google.com>
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Suggested-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/session.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 60fb9997ea0d..d58fc1ed2fdf 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
if (session->header.needs_swap)
event_swap(event, evlist__sample_id_all(evlist));
- if (event->header.type >= PERF_RECORD_HEADER_MAX)
- return -EINVAL;
+ if (event->header.type >= PERF_RECORD_HEADER_MAX) {
+ /* This perf is outdated and does not support the latest event type. */
+ ui__warning("Unsupported type %u, please considering update perf.\n",
+ event->header.type);
+ /* Skip the supported event by returning its size. */
+ return event->header.size;
+ }
events_stats__inc(&evlist->stats, event->header.type);
--
2.49.0.472.ge94155a9ec-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf report: Skip unsupported new event types
2025-03-28 23:01 [PATCH v1] perf report: Skip unsupported new event types Chun-Tse Shao
@ 2025-03-29 0:39 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2025-03-29 0:39 UTC (permalink / raw)
To: Chun-Tse Shao
Cc: linux-kernel, Arnaldo Carvalho de Melo, peterz, mingo,
mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter,
kan.liang, dvyukov, ben.gainey, linux-perf-users
Hello,
On Fri, Mar 28, 2025 at 04:01:57PM -0700, Chun-Tse Shao wrote:
> `perf report` currently halts with an error when encountering
> unsupported new event types (`event.type >= PERF_RECORD_HEADER_MAX`).
> This patch modifies the behavior to skip these samples and continue
> processing the remaining events.
>
> Signed-off-by: Chun-Tse Shao <ctshao@google.com>
> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> Suggested-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/session.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 60fb9997ea0d..d58fc1ed2fdf 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1639,8 +1639,13 @@ static s64 perf_session__process_event(struct perf_session *session,
> if (session->header.needs_swap)
> event_swap(event, evlist__sample_id_all(evlist));
>
> - if (event->header.type >= PERF_RECORD_HEADER_MAX)
> - return -EINVAL;
> + if (event->header.type >= PERF_RECORD_HEADER_MAX) {
> + /* This perf is outdated and does not support the latest event type. */
> + ui__warning("Unsupported type %u, please considering update perf.\n",
> + event->header.type);
> + /* Skip the supported event by returning its size. */
> + return event->header.size;
Please make sure if the size is 8-byte aligned.
Thanks,
Namhyung
> + }
>
> events_stats__inc(&evlist->stats, event->header.type);
>
> --
> 2.49.0.472.ge94155a9ec-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-29 0:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 23:01 [PATCH v1] perf report: Skip unsupported new event types Chun-Tse Shao
2025-03-29 0:39 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).