From: Michel Lind <michel@michel-slm.name>
To: linux-perf-users <linux-perf-users@vger.kernel.org>
Subject: Re: Recent tarballs missing some files
Date: Mon, 25 Nov 2024 17:50:28 -0600 [thread overview]
Message-ID: <Z0UNRCRYKunbDYxP@hyperscale.parallels> (raw)
In-Reply-To: <Z0S9HCQ0Z2d/I+Uh@hyperscale.parallels>
[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]
On Mon, Nov 25, 2024 at 12:08:28PM -0600, Michel Lind wrote:
> Hello all,
>
> Per discussions with acme back at LPC, I'm working on packaging a
> standalone perf RPM, initially for the CentOS Hyperscale SIG and
> potentially for Fedora later on.
>
> I noticed that, while perf 6.9.0 builds fine from the source tarball,
> more recent versions (at least 6.11 and 6.12) fails due to a missing
> header:
>
> ```
> In file included from /builddir/build/BUILD/perf-6.12.0/tools/include/uapi/linux/bpf_perf_event.h:11,
> from libbpf.c:36:
> /builddir/build/BUILD/perf-6.12.0/tools/include/uapi/asm/bpf_perf_event.h:2:10: fatal error: ../../arch/arm64/include/uapi/asm/bpf_perf_event.h: No such file or directory
> 2 | #include "../../arch/arm64/include/uapi/asm/bpf_perf_event.h"
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> ```
>
> I can submit a patch to fix this (and any other missing files), if
> someone could point me to where the script is that generates the perf
> tarballs.
>
Update - on digging in this only happens on aarch64 (probably why this
was not caught earlier). And it also affects 6.9.0. In all cases the
alternatives are either copying in that one header *or* passing
NO_LIBBPF=1
Once I know which script to update, the other thing I want to do is make
it bundle a copy of the COPYING file, since we ideally have that for
standalone distribution
perf now built for Hyperscale experimental and facebook repos - the only
difference is the facebook build has Perl support disabled
https://cbs.centos.org/koji/packageinfo?packageID=11475
I'll promote it to an official Hyperscale package once I figure out how
to build with the standard optimization flags in addition to the ones
perf overrides.
Best regards,
--
_o) Michel Lind
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-11-25 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 18:08 Recent tarballs missing some files Michel Lind
2024-11-25 23:50 ` Michel Lind [this message]
[not found] ` <CA+JHD91LPXRadmVckNMSf-zMNuJsEO1_pk0JC57XdVQczadwgA@mail.gmail.com>
2024-11-26 3:26 ` Michel Lind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0UNRCRYKunbDYxP@hyperscale.parallels \
--to=michel@michel-slm.name \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).