From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8D82594A3; Wed, 11 Dec 2024 19:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733946300; cv=none; b=dT/BoPqaQSmSYRBHSi6PpBw0Nb8sriR0rIvow+bve6QZ22RvtqkXW7TuMcr/KyZjO9oCCTMbtHwt017RY7Xt+sG46A20BIsi+2OCOmbEev1LqLE63EjXa8Ei9i4QGdlDRIOIEwnhOYvlfhrrncPLnb060jaqXsXM52CDdsRamsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733946300; c=relaxed/simple; bh=Vg5J7bpAvisbUNV39Kztftl751Y5mcACEYs59HWtPXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fpx4q33okgOohDgPJ2xpr3MJxET6fKdnwXgEIMhxuAzBmyUtI7sg3XuRejMgERQm3+GoT+pxBuLfT3lPbhS7fbGP06ciYgZOUeuks9TCNEoLVXDLfyrh1W9fBAxNra8UWxnkOiSA1m986ekJd+p4UiaNgxNqHDSiN1GTSv9WjZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U1ypOQiC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U1ypOQiC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1AEC4CED2; Wed, 11 Dec 2024 19:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733946300; bh=Vg5J7bpAvisbUNV39Kztftl751Y5mcACEYs59HWtPXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U1ypOQiCKPrkxaqswbp3KsfOLkxNoA6awtMlQRFcChWZUsahcP+A3nGj2WHwkqIw1 gs5LLOAOy2AwfWCaz44UwA7wTxXf5+H3gbT501YuCHjtEgDopPWCECGYe7bg8ti274 KSiROl4NJHcg4Nigwp85tkIc62G2VZ76JgHmHhtp2t99+orRlr7Hvn04LN/PScfS9F TE0h1BvNO3GzC+LnCv7Y8JvBt+sdaU6gThk9Jtn0OXyp0sSAu4MasfXbKtEHzP+xrk lZSq/rUuuCp0Afapu7crxZ1Gp2PTdNnu7+RQYm+30oc5mkkOwApTpVAnRmAUZVQ90A tMDkzv31rGnBw== Date: Wed, 11 Dec 2024 11:44:57 -0800 From: Namhyung Kim To: Leo Yan Cc: Quentin Monnet , Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Nick Terrell , Ian Rogers , Adrian Hunter , "Liang, Kan" , James Clark , Guilherme Amadio , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v2 0/3] bpftool: Fix the static linkage failure Message-ID: References: <20241211093114.263742-1-leo.yan@arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241211093114.263742-1-leo.yan@arm.com> On Wed, Dec 11, 2024 at 09:31:11AM +0000, Leo Yan wrote: > This series follows up on the discussion in [1] for fixing the static > linkage issue in bpftool. > > Patch 01 introduces a new feature for libelf-zstd. If this feature > is detected, it means the zstd lib is required by libelf. > > Patch 02 is a minor improvement for linking the zstd lib in the perf. > > Patch 03 fixes the static build failure by linking the zstd lib when > the feature-libelf-zstd is detected. > > [1] https://lore.kernel.org/linux-perf-users/Z1H9-9xrWM4FBbNI@mini-arch/T/#m2300b127424e9e2ace7da497a20d88534eb6866f > > > Leo Yan (3): > tools build: Add feature test for libelf with ZSTD > perf: build: Minor improvement for linking libzstd > bpftool: Link zstd lib required by libelf Tested-by: Namhyung Kim Thanks, Namhyung > > tools/bpf/bpftool/Makefile | 8 ++++++++ > tools/build/Makefile.feature | 1 + > tools/build/feature/Makefile | 4 ++++ > tools/build/feature/test-all.c | 4 ++++ > tools/build/feature/test-libelf-zstd.c | 9 +++++++++ > tools/perf/Makefile.config | 8 +++++++- > 6 files changed, 33 insertions(+), 1 deletion(-) > create mode 100644 tools/build/feature/test-libelf-zstd.c > > -- > 2.34.1 >