From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, mhiramat@kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@arm.com>, Dima Kogan <dima@secretsauce.net>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf probe: Fix uninitialized variable
Date: Wed, 11 Dec 2024 23:08:53 -0800 [thread overview]
Message-ID: <Z1qMBSkp7Ry0LEOd@google.com> (raw)
In-Reply-To: <Z1nJdd3YF5YGvlqp@google.com>
On Wed, Dec 11, 2024 at 09:18:45AM -0800, Namhyung Kim wrote:
> Hello,
>
> On Wed, Dec 11, 2024 at 10:15:30AM -0300, Arnaldo Carvalho de Melo wrote:
> > On Wed, Dec 11, 2024 at 08:55:23AM +0000, James Clark wrote:
> > > Since the linked fixes: commit, err is returned uninitialized due to the
> > > removal of "return 0". Initialize err to fix it.
> > >
> > > This fixes the following intermittent test failure on release builds:
> > >
> > > $ perf test "testsuite_probe"
> > > ...
> > > -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing)
> > > Regexp not found: \"Error: switch .+ cannot be used with switch .+\"
> > > ...
> >
> > So Namhyung, this one should go to perf-tools, I can pick the second on
> > perf-tools-next, so that we keep perf-tools as small as possible.
>
> Sure, will replace and force-push.
Applied patch 1 to perf-tools, thanks!
Best regards,
Namhyung
next prev parent reply other threads:[~2024-12-12 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 8:55 [PATCH v2 0/2] perf probe: Fix uninitialized variable James Clark
2024-12-11 8:55 ` [PATCH v2 1/2] " James Clark
2024-12-11 13:15 ` Arnaldo Carvalho de Melo
2024-12-11 17:18 ` Namhyung Kim
2024-12-12 7:08 ` Namhyung Kim [this message]
2024-12-11 8:55 ` [PATCH v2 2/2] perf probe: Rename err label James Clark
2025-01-13 15:47 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1qMBSkp7Ry0LEOd@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dima@secretsauce.net \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).