From: Namhyung Kim <namhyung@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Guo Ren" <guoren@kernel.org>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>, "Jonathan Corbet" <corbet@lwn.net>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-security-module@vger.kernel.org, bpf@vger.kernel.org,
linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 02/16] perf tools: arc: Support generic syscall headers
Date: Fri, 13 Dec 2024 15:51:48 -0800 [thread overview]
Message-ID: <Z1zIlKq19lAXMoGs@google.com> (raw)
In-Reply-To: <20241212-perf_syscalltbl-v2-2-f8ca984ffe40@rivosinc.com>
On Thu, Dec 12, 2024 at 04:32:52PM -0800, Charlie Jenkins wrote:
> Arc uses the generic syscall table, use that in perf instead of
> requiring libaudit.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
> tools/perf/Makefile.config | 2 +-
> tools/perf/Makefile.perf | 2 +-
> tools/perf/arch/arc/entry/syscalls/Kbuild | 2 ++
> tools/perf/arch/arc/entry/syscalls/Makefile.syscalls | 3 +++
> tools/perf/arch/arc/include/syscall_table.h | 2 ++
> 5 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index a72f25162714f0117a88d94474da336814d4f030..3959a9c9972999f6d1bb85e8c1d7dc5dce92fd09 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -36,7 +36,7 @@ ifneq ($(NO_SYSCALL_TABLE),1)
> endif
>
> # architectures that use the generic syscall table scripts
> - ifeq ($(SRCARCH),riscv)
> + ifeq ($(SRCARCH),$(filter $(SRCARCH),riscv arc))
This might work as well.
ifneq ($(filter $(SRCARCH), riscv arc),)
And maybe you can add a variable for supported archs.
Thanks,
Namhyung
> NO_SYSCALL_TABLE := 0
> CFLAGS += -DGENERIC_SYSCALL_TABLE
> CFLAGS += -I$(OUTPUT)/tools/perf/arch/$(SRCARCH)/include/generated
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index f5278ed9f778f928436693a14e016c5c3c5171c1..3b463b42b0e3982e74056e672b2ee6adad5a3f0e 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -311,7 +311,7 @@ FEATURE_TESTS := all
> endif
> endif
> # architectures that use the generic syscall table
> -ifeq ($(SRCARCH),riscv)
> +ifeq ($(SRCARCH),$(filter $(SRCARCH),riscv arc))
> include $(srctree)/tools/perf/scripts/Makefile.syscalls
> endif
> include Makefile.config
> diff --git a/tools/perf/arch/arc/entry/syscalls/Kbuild b/tools/perf/arch/arc/entry/syscalls/Kbuild
> new file mode 100644
> index 0000000000000000000000000000000000000000..11707c481a24ecf4e220e51eb1aca890fe929a13
> --- /dev/null
> +++ b/tools/perf/arch/arc/entry/syscalls/Kbuild
> @@ -0,0 +1,2 @@
> +# SPDX-License-Identifier: GPL-2.0
> +syscall-y += syscalls_32.h
> diff --git a/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls b/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls
> new file mode 100644
> index 0000000000000000000000000000000000000000..391d30ab7a831b72d2ed3f2e7966fdbf558a9ed7
> --- /dev/null
> +++ b/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +syscall_abis_32 += arc time32 renameat stat64 rlimit
> diff --git a/tools/perf/arch/arc/include/syscall_table.h b/tools/perf/arch/arc/include/syscall_table.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..4c942821662d95216765b176a84d5fc7974e1064
> --- /dev/null
> +++ b/tools/perf/arch/arc/include/syscall_table.h
> @@ -0,0 +1,2 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#include <asm/syscalls_32.h>
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-12-13 23:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 0:32 [PATCH v2 00/16] perf tools: Use generic syscall scripts for all archs Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 01/16] perf tools: Create generic syscall table support Charlie Jenkins
2024-12-13 23:22 ` Namhyung Kim
2024-12-17 5:05 ` Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 02/16] perf tools: arc: Support generic syscall headers Charlie Jenkins
2024-12-13 23:51 ` Namhyung Kim [this message]
2024-12-17 5:30 ` Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 03/16] perf tools: csky: " Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 04/16] perf tools: arm: Support " Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 05/16] perf tools: sh: " Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 06/16] perf tools: sparc: " Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 07/16] perf tools: xtensa: Support syscall header Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 08/16] perf tools: x86: Use generic syscall scripts Charlie Jenkins
2024-12-13 0:32 ` [PATCH v2 09/16] perf tools: alpha: Support syscall header Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 10/16] perf tools: parisc: " Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 11/16] perf tools: arm64: Use syscall table Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 12/16] perf tools: loongarch: " Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 13/16] perf tools: mips: Use generic syscall scripts Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 14/16] perf tools: powerpc: Use generic syscall table scripts Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 15/16] perf tools: s390: " Charlie Jenkins
2024-12-13 0:33 ` [PATCH v2 16/16] perf tools: Remove dependency on libaudit Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1zIlKq19lAXMoGs@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=charlie@rivosinc.com \
--cc=corbet@lwn.net \
--cc=gnoack@google.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mic@digikod.net \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).