From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBBC153BF8 for ; Tue, 17 Dec 2024 05:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734413447; cv=none; b=IuL2ihWjdzOourOgRuqavsnlZIB0Y+gm4p8cRAm202PxFEXQQvQJlD6Q0SZYRkNWqHqujge34vkVfRQAE/sr9H6cenn99xBNjMXb1yu61u9FG6M4yPFx5MwW6V6p+/hCTPky6IVAwcoTJOKmRpAoCRuvZKIoxe59lLf8imcIg7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734413447; c=relaxed/simple; bh=NXcQdo0wRRKb2/WNDagRZfaOG1sq8tDTThIxnEioR2U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RkaF/xyGRGscGj3u9CBCckO4TO7aYuXiR4zzzw3Z14w9h5oCXnRvtNdIiBOf+hlOr3BFTbozkzc6F8aLm1S1Qft1RdF/+A81nDNToOzG8HCY5Pvpoks5HOC6oGxBC+gZw6ifXLtaNHallhSBiPx6E6ZDGCWtQ/OYmMVtkkhUS6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=G3E8wujk; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="G3E8wujk" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-728e78c4d7bso3548617b3a.0 for ; Mon, 16 Dec 2024 21:30:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1734413443; x=1735018243; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3eprAB6mL99nuDvuDpZ7xteMR+o2NtdFYL2yb/syKiQ=; b=G3E8wujkDoPb5DgpzmCfuvZsQOGcrS92LDJRcjmjK6pq9ot5malWkaYU15mvJ8FEmB +Q+Ms3gzw9vo2LoxeJBVo2zrCXgOWa01I0IKCrJCFWJyD0naf00xciH8vTot2hIUjoMJ ElIgCuqOzEshWo+4NpzmMazwJ6sCFHyN9abVILbqri9UXMSFulPpdqnvCGplq9ynI/kJ gpNuezQA95tLAMRKtn9nk0tJL/zaMqRgPCDE1+P6GwXGP2yVLlWR0zVwmX0FZsZWeNDq 3qAnpJL8TXHrn84zKL6ov3ZB1p0RfmcV+doHCQkk4lfyVLf1wKDa0WD1uz8zKBuzlWzl v9uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734413443; x=1735018243; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3eprAB6mL99nuDvuDpZ7xteMR+o2NtdFYL2yb/syKiQ=; b=mNyegRduqCR6S0x6agOVMQe3d5fqFLogPQyeFf9FofYqS91/lz9xgYLqTNb3Ha9gTx VhhZ0fMoQBJSQx5H/zxcVMVYNtuQsDDpbj6Uqfs/LjIePWY6Y3LRxvMF91UUjmgfhiuv qBxsh6s7bzKNuL6GeNDECcN772nTpSPFZTwHOAx4d/Rnh61HSy4m+r7mk9XuwR4qsmZ4 71iOoklutBbIB8Gmt8lUoogoY35RQJCd9oviV3gpSgWc4oWLzozKf0riPPJAmYSHSJN5 y+aktxuD9pHdY+A/UMf2SJjoR/KjW8oyX/oRSbBEgpK7TP25QYPY6gMUi++I6oTe1zj2 znhQ== X-Forwarded-Encrypted: i=1; AJvYcCXBiyLeYhDPBiavCFDk2pGBJ9meI/eSrPLrDEFKHNKjuDvfvY1h6JaTfbkdwSbn7cK4UXV78AcfOQLsuLWbNSiZ@vger.kernel.org X-Gm-Message-State: AOJu0YwHWKCsEHlBJBeGQblEUNCqtDfrWviBW2JqKk+CnmazDnF8tr5w 3M6KrwKUAyeXeR1DvqlzEEfTPVqpDwFdSHfaUSOJdXPY8iVlVM3Db4Zru8nzzFY= X-Gm-Gg: ASbGncv9TT2kSIj/ag9Q2HfTg1xy2XviO4geD2DUT+U1+AZ0pYZJvB2C5utHngvm4UM SS7l6P+03mZtMK4q/wPP51KT+VBf8nZ8LW0BeQtL/Yk6awxCZ+ctrgLeYLiWAIZHBlp1w0VmOLr 4lqbNU6Oke6rdf6YlWVbAAAziMBVzbRvDP19My3+1Baas6RGqrRoYB4ZOESgV0g2ZY8XqmsRdAF mNgeY9570GP64gS+6zH77LKAjYvjhASnQ+liL5CwIpKvtXGblc= X-Google-Smtp-Source: AGHT+IGGG8XVKg+X8rmGZK6CbMCJ7mkfFmLPI5+tN+Ymugv6wmhrKZix3qMLXbksYQCVWS+ftd5fVg== X-Received: by 2002:a05:6a00:7c6:b0:725:e386:3c5b with SMTP id d2e1a72fcca58-72a7872b694mr2639309b3a.5.1734413443517; Mon, 16 Dec 2024 21:30:43 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:9708:a71e:40e6:860]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918ad5883sm5945241b3a.63.2024.12.16.21.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 21:30:42 -0800 (PST) Date: Mon, 16 Dec 2024 21:30:39 -0800 From: Charlie Jenkins To: Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Guo Ren , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Jonathan Corbet , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 02/16] perf tools: arc: Support generic syscall headers Message-ID: References: <20241212-perf_syscalltbl-v2-0-f8ca984ffe40@rivosinc.com> <20241212-perf_syscalltbl-v2-2-f8ca984ffe40@rivosinc.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 13, 2024 at 03:51:48PM -0800, Namhyung Kim wrote: > On Thu, Dec 12, 2024 at 04:32:52PM -0800, Charlie Jenkins wrote: > > Arc uses the generic syscall table, use that in perf instead of > > requiring libaudit. > > > > Signed-off-by: Charlie Jenkins > > --- > > tools/perf/Makefile.config | 2 +- > > tools/perf/Makefile.perf | 2 +- > > tools/perf/arch/arc/entry/syscalls/Kbuild | 2 ++ > > tools/perf/arch/arc/entry/syscalls/Makefile.syscalls | 3 +++ > > tools/perf/arch/arc/include/syscall_table.h | 2 ++ > > 5 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > > index a72f25162714f0117a88d94474da336814d4f030..3959a9c9972999f6d1bb85e8c1d7dc5dce92fd09 100644 > > --- a/tools/perf/Makefile.config > > +++ b/tools/perf/Makefile.config > > @@ -36,7 +36,7 @@ ifneq ($(NO_SYSCALL_TABLE),1) > > endif > > > > # architectures that use the generic syscall table scripts > > - ifeq ($(SRCARCH),riscv) > > + ifeq ($(SRCARCH),$(filter $(SRCARCH),riscv arc)) > > This might work as well. > > ifneq ($(filter $(SRCARCH), riscv arc),) > > And maybe you can add a variable for supported archs. Yeah I can do that. All of this is just temporary though. The final patch removes all of this, since this series implements this for every architecture. - Charlie > > Thanks, > Namhyung > > > > NO_SYSCALL_TABLE := 0 > > CFLAGS += -DGENERIC_SYSCALL_TABLE > > CFLAGS += -I$(OUTPUT)/tools/perf/arch/$(SRCARCH)/include/generated > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > index f5278ed9f778f928436693a14e016c5c3c5171c1..3b463b42b0e3982e74056e672b2ee6adad5a3f0e 100644 > > --- a/tools/perf/Makefile.perf > > +++ b/tools/perf/Makefile.perf > > @@ -311,7 +311,7 @@ FEATURE_TESTS := all > > endif > > endif > > # architectures that use the generic syscall table > > -ifeq ($(SRCARCH),riscv) > > +ifeq ($(SRCARCH),$(filter $(SRCARCH),riscv arc)) > > include $(srctree)/tools/perf/scripts/Makefile.syscalls > > endif > > include Makefile.config > > diff --git a/tools/perf/arch/arc/entry/syscalls/Kbuild b/tools/perf/arch/arc/entry/syscalls/Kbuild > > new file mode 100644 > > index 0000000000000000000000000000000000000000..11707c481a24ecf4e220e51eb1aca890fe929a13 > > --- /dev/null > > +++ b/tools/perf/arch/arc/entry/syscalls/Kbuild > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +syscall-y += syscalls_32.h > > diff --git a/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls b/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls > > new file mode 100644 > > index 0000000000000000000000000000000000000000..391d30ab7a831b72d2ed3f2e7966fdbf558a9ed7 > > --- /dev/null > > +++ b/tools/perf/arch/arc/entry/syscalls/Makefile.syscalls > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +syscall_abis_32 += arc time32 renameat stat64 rlimit > > diff --git a/tools/perf/arch/arc/include/syscall_table.h b/tools/perf/arch/arc/include/syscall_table.h > > new file mode 100644 > > index 0000000000000000000000000000000000000000..4c942821662d95216765b176a84d5fc7974e1064 > > --- /dev/null > > +++ b/tools/perf/arch/arc/include/syscall_table.h > > @@ -0,0 +1,2 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#include > > > > -- > > 2.34.1 > >