From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Chen Ni" <nichen@iscas.ac.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] perf annotate: Prefer passing evsel to evsel->core.idx
Date: Fri, 20 Dec 2024 16:50:36 -0300 [thread overview]
Message-ID: <Z2XKjPau1uPgKqro@x1> (raw)
In-Reply-To: <20241114230713.330701-4-irogers@google.com>
On Thu, Nov 14, 2024 at 03:07:13PM -0800, Ian Rogers wrote:
> An evsel idx may not be stable due to sorting, evlist removal,
> etc. Try to reduce it being part of APIs by explicitly passing the
> evsel in annotate code. Internally the code just reads evsel->core.idx
> so behavior is unchanged.
I think this is where this comes into play, are you running 'make -C
tools/perf tools-build' before submitting?
I'll have to stop now, but will fix this if you don´t have time for a
v2.
- Arnaldo
ui/gtk/annotate.c: In function ‘perf_gtk__get_percent’:
ui/gtk/annotate.c:45:48: error: passing argument 2 of ‘annotation__histogram’ makes pointer from integer without a cast [-Wint-conversion]
45 | symhist = annotation__histogram(notes, evidx);
| ^~~~~
| |
| int
In file included from ui/gtk/annotate.c:5:
/home/acme/git/perf-tools-next/tools/perf/util/annotate.h:383:74: note: expected ‘const struct evsel *’ but argument is of type ‘int’
383 | const struct evsel *evsel)
| ~~~~~~~~~~~~~~~~~~~~^~~~~
ui/gtk/annotate.c:46:58: error: passing argument 2 of ‘annotated_source__hist_entry’ makes pointer from integer without a cast [-Wint-conversion]
46 | entry = annotated_source__hist_entry(notes->src, evidx, dl->al.offset);
| ^~~~~
| |
| int
/home/acme/git/perf-tools-next/tools/perf/util/annotate.h:389:80: note: expected ‘const struct evsel *’ but argument is of type ‘int’
389 | annotated_source__hist_entry(struct annotated_source *src, const struct evsel *evsel, u64 offset)
| ~~~~~~~~~~~~~~~~~~~~^~~~~
TEST tests/shell/test_task_analyzer.sh.shellcheck_log
make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:105: ui/gtk/annotate.o] Error 1
TEST tests/shell/test_uprobe_from_different_cu.sh.shellcheck_log
CC util/session.o
make[5]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:158: ui/gtk] Error 2
make[4]: *** [Makefile.perf:802: gtk-in.o] Error 2
make[4]: *** Waiting for unfinished jobs....
CC util/tool.o
next prev parent reply other threads:[~2024-12-20 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 23:07 [PATCH v1 0/3] Prefer evsel over evsel->core.idx Ian Rogers
2024-11-14 23:07 ` [PATCH v1 1/3] perf stream: Use evsel rather than evsel->idx Ian Rogers
2024-11-14 23:07 ` [PATCH v1 2/3] perf values: " Ian Rogers
2024-11-14 23:07 ` [PATCH v1 3/3] perf annotate: Prefer passing evsel to evsel->core.idx Ian Rogers
2024-12-20 19:50 ` Arnaldo Carvalho de Melo [this message]
2024-11-18 10:18 ` [PATCH v1 0/3] Prefer evsel over evsel->core.idx James Clark
2024-12-14 0:13 ` Namhyung Kim
2024-12-20 18:57 ` Ian Rogers
2024-12-20 19:45 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2XKjPau1uPgKqro@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=namhyung@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox