From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: linux@treblig.org
Cc: Carsten Haitzler <carsten.haitzler@arm.com>,
irogers@google.com, peterz@infradead.org, mingo@redhat.com,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, kan.liang@linux.intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Remove unused is_executable_file
Date: Mon, 23 Dec 2024 13:37:24 -0300 [thread overview]
Message-ID: <Z2mRxByYb-GIi0UU@x1> (raw)
In-Reply-To: <Z2mQ4RdSE_EfbGyO@x1>
On Mon, Dec 23, 2024 at 01:33:41PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Dec 23, 2024 at 01:32:15PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Sun, Dec 22, 2024 at 09:58:31PM +0000, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > is_executable_file() has been unused since 2022's
> > > commit 7391db645938 ("perf test: Refactor shell tests allowing subdirs")
> > > Remove it.
> > Did you patch this on:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next
> > ?
> > That function is still there, so I'll fixup your patch, keep your
> > credits and test it all.
>
> FYI, it fails on the .h file:
I also added Carsten to the CC list, since he is the author of the
mentioned commit where that function stopped being used.
- Arnaldo
next prev parent reply other threads:[~2024-12-23 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 21:58 [PATCH] perf tools: Remove unused is_executable_file linux
2024-12-23 16:32 ` Arnaldo Carvalho de Melo
2024-12-23 16:33 ` Arnaldo Carvalho de Melo
2024-12-23 16:37 ` Arnaldo Carvalho de Melo [this message]
2024-12-23 16:41 ` Dr. David Alan Gilbert
2024-12-23 16:36 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2mRxByYb-GIi0UU@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox