* [PATCH] perf llvm-add2line: Remove unused include
@ 2025-01-08 7:02 Dmitry Vyukov
2025-01-08 20:39 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Vyukov @ 2025-01-08 7:02 UTC (permalink / raw)
To: namhyung, irogers; +Cc: Dmitry Vyukov, linux-perf-users, linux-kernel
Remove unused symbol_conf.h include.
First, it's just unused. Second, it's problematic since this is a C++ file,
and most perf headers don't compile as C++. So if any other includes are
added to symbol_conf.h, it may break the build.
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
tools/perf/util/llvm-c-helpers.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/llvm-c-helpers.cpp b/tools/perf/util/llvm-c-helpers.cpp
index 663bcaba2041f..004081bd12c9c 100644
--- a/tools/perf/util/llvm-c-helpers.cpp
+++ b/tools/perf/util/llvm-c-helpers.cpp
@@ -18,7 +18,6 @@
extern "C" {
#include <linux/zalloc.h>
}
-#include "symbol_conf.h"
#include "llvm-c-helpers.h"
extern "C"
base-commit: 09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780
--
2.47.1.613.gc27f4b7a9f-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf llvm-add2line: Remove unused include
2025-01-08 7:02 [PATCH] perf llvm-add2line: Remove unused include Dmitry Vyukov
@ 2025-01-08 20:39 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2025-01-08 20:39 UTC (permalink / raw)
To: Dmitry Vyukov; +Cc: namhyung, irogers, linux-perf-users, linux-kernel
On Wed, Jan 08, 2025 at 08:02:28AM +0100, Dmitry Vyukov wrote:
> Remove unused symbol_conf.h include.
> First, it's just unused. Second, it's problematic since this is a C++ file,
> and most perf headers don't compile as C++. So if any other includes are
> added to symbol_conf.h, it may break the build.
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Ian Rogers <irogers@google.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> tools/perf/util/llvm-c-helpers.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/llvm-c-helpers.cpp b/tools/perf/util/llvm-c-helpers.cpp
> index 663bcaba2041f..004081bd12c9c 100644
> --- a/tools/perf/util/llvm-c-helpers.cpp
> +++ b/tools/perf/util/llvm-c-helpers.cpp
> @@ -18,7 +18,6 @@
> extern "C" {
> #include <linux/zalloc.h>
> }
> -#include "symbol_conf.h"
> #include "llvm-c-helpers.h"
>
> extern "C"
>
> base-commit: 09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780
> --
> 2.47.1.613.gc27f4b7a9f-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-08 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 7:02 [PATCH] perf llvm-add2line: Remove unused include Dmitry Vyukov
2025-01-08 20:39 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).