From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [BUG] perf top reports not being able to resolve kernel symbols
Date: Thu, 2 Jan 2025 22:16:35 -0300 [thread overview]
Message-ID: <Z3c6cwACnzku_ntQ@x1> (raw)
In-Reply-To: <Z3b-DqBMnNb4ucEm@google.com>
On Thu, Jan 02, 2025 at 12:58:54PM -0800, Namhyung Kim wrote:
> On Thu, Jan 02, 2025 at 04:51:06PM -0300, Arnaldo Carvalho de Melo wrote:
> > So there are symbols that are not being resolved anymore that were
> > before your patch, namely:
> > arch/x86/entry/entry_64.S
> > nmi_no_fsgsbase:
> > /* EBX == 0 -> invoke SWAPGS */
> > testl %ebx, %ebx
> > jnz nmi_restore
> > nmi_swapgs:
> > swapgs
> > nmi_restore:
> > POP_REGS
> Sorry about that, maybe I should've done this instead. Can you check
> if it works correctly?
Its late here, but basic test shows samples being resolved to
nmi_restore, when using the TUI 'perf top' interface and pressing / to
ask for samples resolved to samples with 'nmi' on its name, several
other such routines appeared on the radar, including:
Samples: 2K of event 'cpu_atom/cycles/P', 4000 Hz, Event count (approx.): 496683332 lost: 0/0 drop: 0/0
Overhead Shared O Symbol
0.05% [kernel] [k] ct_nmi_enter
0.04% [kernel] [k] local_touch_nmi
0.01% [kernel] [k] ct_nmi_exit
0.01% [kernel] [k] nmi_restore
0.00% [kernel] [k] nmi_handle
[1]+ Stopped perf top
root@number:~#
So:
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
And preliminarly:
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Thanks, I'll submit the other patch, that now doesn't need to go into
the 6.13 window and thus can be added to the perf-tools-next branch,
tomorrow.
- Arnaldo
next prev parent reply other threads:[~2025-01-03 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 18:41 [BUG] perf top reports not being able to resolve kernel symbols Arnaldo Carvalho de Melo
2025-01-02 19:25 ` Arnaldo Carvalho de Melo
2025-01-02 19:51 ` Arnaldo Carvalho de Melo
2025-01-02 20:58 ` Namhyung Kim
2025-01-03 1:16 ` Arnaldo Carvalho de Melo [this message]
2025-01-03 16:33 ` Arnaldo Carvalho de Melo
2025-01-09 21:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3c6cwACnzku_ntQ@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).