From: Charlie Jenkins <charlie@rivosinc.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] tools: perf: tests: Fix code reading for riscv
Date: Fri, 3 Jan 2025 11:15:22 -0800 [thread overview]
Message-ID: <Z3g3SrBwQcXWdbRr@ghost> (raw)
In-Reply-To: <Z3gVrzFd_2cacOFD@x1>
On Fri, Jan 03, 2025 at 01:51:59PM -0300, Arnaldo Carvalho de Melo wrote:
> On Thu, Jan 02, 2025 at 05:44:56PM -0800, Charlie Jenkins wrote:
> > On Wed, Dec 18, 2024 at 05:52:24PM -0800, Charlie Jenkins wrote:
> > > On Wed, Dec 18, 2024 at 05:20:15PM -0800, Ian Rogers wrote:
> > > Yeah I agree. This test case did end up being interesting though as it
> > > unconvered this change in behavior of objdump on riscv, but that's
> > > tangential to the purpose of this test case. We need this patch on riscv
> > > to stop this test from failing, but it is also reasonable to approach
> > > this differently and not use objdump at all.
>
> > What's the next step here? Would you prefer to get rid of this test
> > entirely? I sent out a v3 that uses uname [1].
>
> > Link
> > https://lore.kernel.org/lkml/20241219-perf_fix_riscv_obj_reading-v3-1-a7d644dcfa50@rivosinc.com/
> > [1]
>
> I'm ok with this latest version and added it to perf-tools-next,
> changing the patch subject line to:
>
> perf tests code-reading: Handle change in objdump output from binutils >= 2.41 on riscv
>
> Ok?
Yes that is perfect, thank you!
- Charlie
>
> - Arnaldo
next prev parent reply other threads:[~2025-01-03 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 23:52 [PATCH v2] tools: perf: tests: Fix code reading for riscv Charlie Jenkins
2024-12-18 0:18 ` Ian Rogers
2024-12-18 0:30 ` Charlie Jenkins
2024-12-18 0:55 ` Ian Rogers
2024-12-18 18:41 ` Arnaldo Carvalho de Melo
2024-12-18 19:23 ` Ian Rogers
2024-12-18 21:02 ` Charlie Jenkins
2024-12-18 22:13 ` Ian Rogers
2024-12-18 22:32 ` Charlie Jenkins
2024-12-19 1:20 ` Ian Rogers
2024-12-19 1:52 ` Charlie Jenkins
2025-01-03 1:44 ` Charlie Jenkins
2025-01-03 16:51 ` Arnaldo Carvalho de Melo
2025-01-03 19:15 ` Charlie Jenkins [this message]
2024-12-18 20:57 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3g3SrBwQcXWdbRr@ghost \
--to=charlie@rivosinc.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).