* [PATCH v2] perf: Fix a wrong help message
@ 2025-01-09 15:22 Jiachen Zhang
2025-01-10 0:29 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Jiachen Zhang @ 2025-01-09 15:22 UTC (permalink / raw)
To: linux-kernel
Cc: Jiachen Zhang, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, open list:PERFORMANCE EVENTS SUBSYSTEM
The wrong help message may mislead users. This commit fixes it.
Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
Signed-off-by: Jiachen Zhang <me@jcix.top>
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 048c91960ba9..a5672749f781 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
OPT_STRING(0, "addr2line", &addr2line_path, "path",
"addr2line binary to use for line numbers"),
OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
- "Disable symbol demangling"),
+ "Symbol demangling. Enabled by default, use --no-demangle to disable."),
OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
"Enable kernel symbol demangling"),
OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] perf: Fix a wrong help message
2025-01-09 15:22 [PATCH v2] perf: Fix a wrong help message Jiachen Zhang
@ 2025-01-10 0:29 ` Namhyung Kim
2025-01-10 14:42 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2025-01-10 0:29 UTC (permalink / raw)
To: Jiachen Zhang
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Ian Rogers, Adrian Hunter, Liang, Kan,
open list:PERFORMANCE EVENTS SUBSYSTEM
On Thu, Jan 09, 2025 at 11:22:19PM +0800, Jiachen Zhang wrote:
> The wrong help message may mislead users. This commit fixes it.
>
> Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
> Signed-off-by: Jiachen Zhang <me@jcix.top>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/builtin-report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 048c91960ba9..a5672749f781 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
> OPT_STRING(0, "addr2line", &addr2line_path, "path",
> "addr2line binary to use for line numbers"),
> OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> - "Disable symbol demangling"),
> + "Symbol demangling. Enabled by default, use --no-demangle to disable."),
> OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
> "Enable kernel symbol demangling"),
> OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] perf: Fix a wrong help message
2025-01-10 0:29 ` Namhyung Kim
@ 2025-01-10 14:42 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2025-01-10 14:42 UTC (permalink / raw)
To: Namhyung Kim
Cc: Jiachen Zhang, linux-kernel, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, Liang, Kan, open list:PERFORMANCE EVENTS SUBSYSTEM
On Thu, Jan 09, 2025 at 04:29:57PM -0800, Namhyung Kim wrote:
> On Thu, Jan 09, 2025 at 11:22:19PM +0800, Jiachen Zhang wrote:
> > The wrong help message may mislead users. This commit fixes it.
> >
> > Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
> > Signed-off-by: Jiachen Zhang <me@jcix.top>
>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next,
- Arnaldo
> Thanks,
> Namhyung
>
> > ---
> > tools/perf/builtin-report.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index 048c91960ba9..a5672749f781 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
> > OPT_STRING(0, "addr2line", &addr2line_path, "path",
> > "addr2line binary to use for line numbers"),
> > OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> > - "Disable symbol demangling"),
> > + "Symbol demangling. Enabled by default, use --no-demangle to disable."),
> > OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
> > "Enable kernel symbol demangling"),
> > OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-10 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 15:22 [PATCH v2] perf: Fix a wrong help message Jiachen Zhang
2025-01-10 0:29 ` Namhyung Kim
2025-01-10 14:42 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).