From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Howard Chu <howardchu95@gmail.com>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 0/4] perf trace: Add --summary-mode option
Date: Wed, 12 Feb 2025 21:59:26 +0100 [thread overview]
Message-ID: <Z60Lrs0U0gIF5oaW@x1> (raw)
In-Reply-To: <Z6ztSE_yo2t28w45@google.com>
On Wed, Feb 12, 2025 at 10:49:44AM -0800, Namhyung Kim wrote:
> On Fri, Feb 07, 2025 at 09:25:02PM -0800, Howard Chu wrote:
> > Hello Namhyung,
> >
> > On Wed, Feb 5, 2025 at 12:54 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > >
> > > Hello,
> > >
> > > I've realized that perf trace shows system call summary at the end for
> > > each thread. But sometimes users want to see the global whole system
> > > summary or statistics instead.
> > >
> > > So I've added --summary-mode option like below:
> > >
> > > $ sudo ./perf trace -as --summary-mode=total sleep 1
> > >
> > > Summary of events:
> > >
> > > total, 21580 events
> > >
> > > syscall calls errors total min avg max stddev
> > > (msec) (msec) (msec) (msec) (%)
> > > --------------- -------- ------ -------- --------- --------- --------- ------
> > > epoll_wait 1305 0 14716.712 0.000 11.277 551.529 8.87%
> > > futex 1256 89 13331.197 0.000 10.614 733.722 15.49%
> > > poll 669 0 6806.618 0.000 10.174 459.316 11.77%
> > > ppoll 220 0 3968.797 0.000 18.040 516.775 25.35%
> > > clock_nanosleep 1 0 1000.027 1000.027 1000.027 1000.027 0.00%
> > > epoll_pwait 21 0 592.783 0.000 28.228 522.293 88.29%
> > > nanosleep 16 0 60.515 0.000 3.782 10.123 33.33%
> > > ioctl 510 0 4.284 0.001 0.008 0.182 8.84%
> > > recvmsg 1434 775 3.497 0.001 0.002 0.174 6.37%
> > > write 1393 0 2.854 0.001 0.002 0.017 1.79%
> > > read 1063 100 2.236 0.000 0.002 0.083 5.11%
> > > ...
> > >
> > > Also it changes internal data structure to hash table to track
> > > statistics of syscalls. And removes the rb_resort code.
> > >
> > > v3 changes)
> > > * Add Acked-by from Howard
> > > * Update commit messages (Ian)
> >
> > Sorry for the delay.
> >
> > Reviewed-by: Howard Chu <howardchu95@gmail.com>
>
> Thanks for your review!
>
> Arnaldo and Ian, are you ok with this?
I looked at it quickly, some minor nits, apart from that, for the
series:
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
next prev parent reply other threads:[~2025-02-12 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 20:54 [PATCH v3 0/4] perf trace: Add --summary-mode option Namhyung Kim
2025-02-05 20:54 ` [PATCH v3 1/4] perf trace: Allocate syscall stats only if summary is on Namhyung Kim
2025-02-12 20:50 ` Arnaldo Carvalho de Melo
2025-02-13 3:39 ` Namhyung Kim
2025-02-05 20:54 ` [PATCH v3 2/4] perf trace: Convert syscall_stats to hashmap Namhyung Kim
2025-02-12 20:54 ` Arnaldo Carvalho de Melo
2025-02-05 20:54 ` [PATCH v3 3/4] perf tools: Get rid of now-unused rb_resort.h Namhyung Kim
2025-02-05 20:54 ` [PATCH v3 4/4] perf trace: Add --summary-mode option Namhyung Kim
2025-02-08 5:25 ` [PATCH v3 0/4] " Howard Chu
2025-02-12 18:49 ` Namhyung Kim
2025-02-12 20:59 ` Arnaldo Carvalho de Melo [this message]
2025-02-12 22:10 ` Namhyung Kim
2025-02-13 17:21 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z60Lrs0U0gIF5oaW@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).