From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A5EA27183B; Wed, 12 Feb 2025 20:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739393970; cv=none; b=rDeNKawOpgDap1ORpyVZsy70fJl3TjcbKFKSPAzV94auwhPzxDqytrTq+sX0neGhJH6yfYSs6LcknhFZ/8VLbCleLUOX2MV61qet/FH7jDle+sARjURvunFPnmyw7BCmLSN6xGVBhRD1QgO/Qf8JMP7zQHEjfgJA0Z0ycn3TwzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739393970; c=relaxed/simple; bh=vvO4fA7UDGzp3gyp6q0XcV9qw5De5yApXoCeg3bCz5I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bjlZeuiHuc+54fEsnbmDwNrtNN2q41prO4albJKGlYq1hWnTw4VLqa+haF8Z7C7u0H+1qFVQfCHgzKX6RbrNSvvCBYDUNq02y7a2VW7VQj/qt9CGVHP8LMMCERYtAWqYh6a8BO/ZRpNrArJoZDMl4Hxo496hxD/xFiI4WXN3O/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZkutFDF4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZkutFDF4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CA83C4CEDF; Wed, 12 Feb 2025 20:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739393969; bh=vvO4fA7UDGzp3gyp6q0XcV9qw5De5yApXoCeg3bCz5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZkutFDF4VlxuuNV8MLm7ep9bVbbfIJtGcHHyGoA0Mg9nagHtDm25jcpz6C5nXC8AH OGUEWBpXTke7ndDs1lxCQcvarqMx8Um/mIxwenASo2TiyrpcTHT7bbSoj5RgWUeYdG FqHi0gLPqhhmWR5tdyURw+qD0VpffcKF7EuBNQVgaPFsUpPl1amX1sYRhBKO8pqS2p 00vCknWT/DnqSuMbL6ZMSyj5+7u14Zo55MFnTh2cY4FLkntQ9ewWZ690ShRgfsvVVl HjfrScjhu07NckkI/KH8FQ9Tx8PaCnbrPsh4dGx8BZwXPO2L+dDOnZckP9CRUViCGo T8mE9ewruj70w== Date: Wed, 12 Feb 2025 21:59:26 +0100 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Howard Chu , Ian Rogers , Kan Liang , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v3 0/4] perf trace: Add --summary-mode option Message-ID: References: <20250205205443.1986408-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 12, 2025 at 10:49:44AM -0800, Namhyung Kim wrote: > On Fri, Feb 07, 2025 at 09:25:02PM -0800, Howard Chu wrote: > > Hello Namhyung, > > > > On Wed, Feb 5, 2025 at 12:54 PM Namhyung Kim wrote: > > > > > > Hello, > > > > > > I've realized that perf trace shows system call summary at the end for > > > each thread. But sometimes users want to see the global whole system > > > summary or statistics instead. > > > > > > So I've added --summary-mode option like below: > > > > > > $ sudo ./perf trace -as --summary-mode=total sleep 1 > > > > > > Summary of events: > > > > > > total, 21580 events > > > > > > syscall calls errors total min avg max stddev > > > (msec) (msec) (msec) (msec) (%) > > > --------------- -------- ------ -------- --------- --------- --------- ------ > > > epoll_wait 1305 0 14716.712 0.000 11.277 551.529 8.87% > > > futex 1256 89 13331.197 0.000 10.614 733.722 15.49% > > > poll 669 0 6806.618 0.000 10.174 459.316 11.77% > > > ppoll 220 0 3968.797 0.000 18.040 516.775 25.35% > > > clock_nanosleep 1 0 1000.027 1000.027 1000.027 1000.027 0.00% > > > epoll_pwait 21 0 592.783 0.000 28.228 522.293 88.29% > > > nanosleep 16 0 60.515 0.000 3.782 10.123 33.33% > > > ioctl 510 0 4.284 0.001 0.008 0.182 8.84% > > > recvmsg 1434 775 3.497 0.001 0.002 0.174 6.37% > > > write 1393 0 2.854 0.001 0.002 0.017 1.79% > > > read 1063 100 2.236 0.000 0.002 0.083 5.11% > > > ... > > > > > > Also it changes internal data structure to hash table to track > > > statistics of syscalls. And removes the rb_resort code. > > > > > > v3 changes) > > > * Add Acked-by from Howard > > > * Update commit messages (Ian) > > > > Sorry for the delay. > > > > Reviewed-by: Howard Chu > > Thanks for your review! > > Arnaldo and Ian, are you ok with this? I looked at it quickly, some minor nits, apart from that, for the series: Acked-by: Arnaldo Carvalho de Melo Tested-by: Arnaldo Carvalho de Melo - Arnaldo