From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D3E217671 for ; Tue, 4 Feb 2025 18:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738694090; cv=none; b=ahmsjhFzWmLHcHwBlPo9pLuZ/D47KSPCFLGkTLPfxRPQz4yL9imKLCSqGBkHt1nmkyMog5mxkl0C9xTqWihOK5TCTh/rSJ8CakrVQ7hNF+zCs0IbNTeAnqxDSEHa9fgM+cq+5RfnSjcw86QzkhyKDy8HIZ8dMPTsTJxuLl2GpbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738694090; c=relaxed/simple; bh=qq6/0sgx5ZwS3YIlvXs2lDakwhUURjUKrwBBStrGj7s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AeTFyBZt2kXZy/Olt+nvgYpy9YCpv5vhIUghmesnkqs6wmhRCYOxNpY77iwhRPrtQJnakpyuqER/VYI+H0ZzJGxMQ0UBKXfRMQn1vmjQZ4X7G87s67UqrtUg+LRVty5qDzra7JM+JfNcZrxgXLRYzrzN2NkoMS2lKNde7g18td4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=ucUPB19Y; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="ucUPB19Y" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3d04932a36cso4355345ab.1 for ; Tue, 04 Feb 2025 10:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738694087; x=1739298887; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=M3rTMe+j/2oa4I6gF8pPtcv0zI3NJYxIm/hZ5P5q3zo=; b=ucUPB19YOxYZUMSig59vhoVuBBxfo8GuBjZFosQu9RkvExjHqbv/1hX9ytNvqOjyn1 K9ZEo5cq/IgvteWICnY7IKhr7xmEDm3cBGb/HbSY+9NY9Hkc2rJ/8UaVEsnn85ct7b3/ ASY5MkZSNCl+RgFPIq6sXpj1k3l8P7uroATRkZTrg/JVGx9mSotkG0TiRj7BjlN81nO8 aAF8ocPn3PlDJ7NWXzFqPTHIA5UHAJ6nQ267kpm/Z21rxJ1tbvcLgL/83BSqVRRl33Ft QBfoTX7bb6bzv5hGCuChDUcb54Y6tKPZpJymg0SxFvlOmGwuhu2yYXsZefxnGNUaHeWt GVTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738694087; x=1739298887; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M3rTMe+j/2oa4I6gF8pPtcv0zI3NJYxIm/hZ5P5q3zo=; b=kbl0JZ10tPKcoihoLs1kzGdKwxVSd1DPeDQNtiVMQcNUdheCX+82qHAGgcOzEP1cwZ up2dcWdqaRv3XPi6Rd+b6lhLcYvbmFkkNzd2vKOBsce220IEjvGv3DLuiZ61cKwDBvs6 /X+C1HdKDnsZ18WkrfLuSU04bqPyAHAEdXHgD+ybDRyoQNd3vUKW3PAZkn9JjrOAb+Ui df56XwR9fAAOPPoBLrwsBqRertbT22rafoszineluMqe0Ki/VkStK2btf9MIsBl99UsM /N3LXEKvpShXxex7zuacwo4P4ELZ4Kj5ytDCTlfLUo55poTxzpkCjncgUHUxIEB8M+2k Qeyw== X-Forwarded-Encrypted: i=1; AJvYcCWYCeYU05Ooqph4JJ6tWQ5PlR8tQo1nhzvI9n0MDEfY7tzZ9ybaWwh8yVwYsuO6ymuVK9VFgDH9a75DhQEipEl/@vger.kernel.org X-Gm-Message-State: AOJu0Yzt+ZUA87O5O7LEIN24RNQREvHJAJKAWCufFG6pXZtGXwRN9ugt YFCPqZr6bcPkdISZKYgttCmebhUATvN2Q9qH7rKSIFSukJDGezrCVOCvP2AB4dA= X-Gm-Gg: ASbGncvgJMrWh8H/jB2NrvbYCtEajltdoIRirE+TCtkLK4LHWCSOoy8+TiJ2Y5fNB9N P1KF0aAjobPoUeFD/WXVi6eHusDoYtxs0ck43jfMhCE/75fMT+/xB1qkXfDvQpFuNbTf+Z7Va8h vB1C37aWyyLbEorqi5pVSxCLcsyPp7lHvypQgAtk/PVbNDLVI/E8CugIh0/AEcyUQK3rQ7BM3/O l52yeZhS+G+ZEmztAz7K9cpa6h87+RI07TDJ14/wJEIojM5Y4qafskb2iXtk9EQ3URoHwiJc7TH FlV9EA== X-Google-Smtp-Source: AGHT+IG/BRPtaEZnajjDcpobEpuNb3M6MK2S0ZW69zYjb0ka0RxhjRkwp9wRSC5O0Seo0pB1mdptYQ== X-Received: by 2002:a05:6e02:12eb:b0:3d0:47e3:40bb with SMTP id e9e14a558f8ab-3d047e34217mr16450115ab.4.1738694087183; Tue, 04 Feb 2025 10:34:47 -0800 (PST) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d00a4fd453sm30576535ab.4.2025.02.04.10.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 10:34:46 -0800 (PST) Date: Tue, 4 Feb 2025 10:34:41 -0800 From: Charlie Jenkins To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , Quentin Monnet , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Josh Poimboeuf , Mykola Lysenko , Shuah Khan , Jiri Kosina , Benjamin Tissoires , Steven Rostedt , bpf , LKML , "linux-perf-use." , Linux Power Management , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:HID CORE LAYER" , linux-trace-kernel Subject: Re: [PATCH 0/2] tools: Unify top-level quiet infrastructure Message-ID: References: <20250203-quiet_tools-v1-0-d25c8956e59a@rivosinc.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 04, 2025 at 05:18:42PM +0000, Alexei Starovoitov wrote: > On Tue, Feb 4, 2025 at 12:10 AM Charlie Jenkins wrote: > > > > The quiet infrastructure was moved out of Makefile.build to accomidate > > the new syscall table generation scripts in perf. Syscall table > > generation wanted to also be able to be quiet, so instead of again > > copying the code to set the quiet variables, the code was moved into > > Makefile.perf to be used globally. This was not the right solution. It > > should have been moved even further upwards in the call chain. > > Makefile.include is imported in many files so this seems like a proper > > place to put it. > > > > To: > > > > Signed-off-by: Charlie Jenkins > > --- > > Charlie Jenkins (2): > > tools: Unify top-level quiet infrastructure > > tools: Remove redundant quiet setup > > > > tools/arch/arm64/tools/Makefile | 6 ----- > > tools/bpf/Makefile | 6 ----- > > tools/bpf/bpftool/Documentation/Makefile | 6 ----- > > tools/bpf/bpftool/Makefile | 6 ----- > > tools/bpf/resolve_btfids/Makefile | 2 -- > > tools/bpf/runqslower/Makefile | 5 +--- > > tools/build/Makefile | 8 +----- > > tools/lib/bpf/Makefile | 13 ---------- > > Nack. > libbpf and bpftool are synced independently to github > and released from there. > This change breaks it. Can you explain how it breaks it? Currently bpftool and resolve_btfids don't build quietly so this was an attempt to fix that. - Charlie