From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4115321C9F3 for ; Tue, 4 Feb 2025 23:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738711456; cv=none; b=IPFq8enfkI14aj5wU1LV73i4SOhzSoMfKYzkLoLcVo/6vw8K9HL4ZG/+fKACK+c7HlTOMDYjjZogYeyXJlMIv7FvpAi6XAqr/B2kyqcGyBkqFmhV+IqEESOWB4uzN4UbuflPjelOMW8S3+BqaLJSobqw0rlu8ABY2HfaYKVUawc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738711456; c=relaxed/simple; bh=FEX3Vdh+NEZiYfGk1vrrsJOKApKBG+9+aixlZ2R/lW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gds4jeRbzstXpux33hY9LzL8YnlVS0864c2UR+mpl4T2lfoSMPjpTQquasabot3aWVhmkKJcLEkUhOs6PIqeD077008oBPQZ/99D+A4DEywMvcU/40cwP9xUhDm82ixFnMly0wusAFIbudZh7T6511n05wS3fc+6yy2TWMUyz9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=NIwPyW0u; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="NIwPyW0u" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-844e394395aso155139939f.3 for ; Tue, 04 Feb 2025 15:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738711452; x=1739316252; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7C+mmXcghpctUltjMuPzZT5k+4ILd9aRvVJeIVZ5h7E=; b=NIwPyW0uky7MWvSUA4RrnNlmxM/EWqPpshZxttoVAADQYvbO1fKez3zdMlkX9PhkYD CTJ8uVIWJxJ7+3H6gmYO3lswgiCiktGMZ31AZ0dCBy8zyObMc+zb3FXBBwQbIohuwmiL sg9ATWw4dbquEfcQAv0dx5LlPTt4m8GYEs4fG5mSnf+ynjo02KyG7nTZ+AXtGiivWaBd oQBK7ibjWxaj2ZzmUHVPErbOsg6sf6bG6779s7hUnqak1ifazJqK1x/UL2OI+JmeTKVB J5uopAn9P4bGV+hWWrhFwJb6Lgrt/41Id2uoxvy85xEUG/21O0yfSwA6MENKOLf1iLRy BMdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738711452; x=1739316252; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7C+mmXcghpctUltjMuPzZT5k+4ILd9aRvVJeIVZ5h7E=; b=SPll/0cHBO4Je88vsHDAibxqfguZykMWvQYxlOLO2yP/R7nUXMx+YzzVpEg1ZYFD9G Ejn7MTDFWMJwcqClCkfkOnXEJ9Y2Fm6wyvYndVclgW7iXzGICe9Ohiw4nyqx6xhPJeO7 obuwCeYlVRI5El6bb5uciImSggOOLA83gNbUKuldsurs961Xqxbc8h5DitkER90sXDRC 18+gDrpqdq1PIx5QwqgmT7Iqke/LhiFPGFagGdzfCRdsyij26c1ADJF5W7WZWSFUGSeI qiDaJ+Q/Q9H22wON00aZ52cllni1ekDhjKn0xqfI/jBBDRipAkrcCo8MjLZ4Jh/qMZgL wI6g== X-Forwarded-Encrypted: i=1; AJvYcCVLQRWDUv+l6iHrXT8zVpTsMNtYQarMnw1twVcozC+fp82ezFtrnILx8+B/a1jRpr+TzCoExWKTmUIBkkLcELzf@vger.kernel.org X-Gm-Message-State: AOJu0YwQjnXqHC/SCMUtEMGQaVBrLZP23KZHqkXdCpB+NzfuirVUOSDX N13i407KPkHikf6g4DkSq3rK85n2I0UaBRzHcM4R9h4yLsJ7Mz+rb4y+/H6KylM= X-Gm-Gg: ASbGnctGvYFsL7SqBID+r9hcxLZ2UkodvJUwNhPq1FQTgYIFnPyg55rEkud9HaJIJj5 bDPuNNKE6PALI+C17TQejn2wF7BB0ND2c9VEd6+ebEfGSd9UnrfdYUYYcJ5iMQoTZ0j8AazDukg HSphZSQiYwEuiN2CHFX59G3Suu2WnKj8OLqVwK8zXeQTzn2OZjNzwbQh0pm467mFoB6G8+ydu8W /6HyLC28NypRArPldPnyXJfe2DoSkqV6ENEnc9XjGv42/G09tdrczACn3ZZ61FacV4wr5OE4yGd pja2Og== X-Google-Smtp-Source: AGHT+IFk01l67w5flnt7AW1w/8rmtq99wc4nbdFvSpX2xfx/D9I29fUoitlQP4S1XPO0eaV5SdxmsA== X-Received: by 2002:a05:6602:3711:b0:83a:a305:d9ee with SMTP id ca18e2360f4ac-854ea515978mr94544239f.12.1738711451927; Tue, 04 Feb 2025 15:24:11 -0800 (PST) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ec7458ed1bsm2990762173.4.2025.02.04.15.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 15:24:10 -0800 (PST) Date: Tue, 4 Feb 2025 15:24:07 -0800 From: Charlie Jenkins To: Alexei Starovoitov Cc: Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , Quentin Monnet , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Josh Poimboeuf , Mykola Lysenko , Shuah Khan , Jiri Kosina , Benjamin Tissoires , Steven Rostedt , bpf , LKML , "linux-perf-use." , Linux Power Management , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:HID CORE LAYER" , linux-trace-kernel Subject: Re: [PATCH 0/2] tools: Unify top-level quiet infrastructure Message-ID: References: <20250203-quiet_tools-v1-0-d25c8956e59a@rivosinc.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 04, 2025 at 11:02:42PM +0000, Alexei Starovoitov wrote: > On Tue, Feb 4, 2025 at 7:04 PM Namhyung Kim wrote: > > > > Hello, > > > > On Tue, Feb 04, 2025 at 10:34:41AM -0800, Charlie Jenkins wrote: > > > On Tue, Feb 04, 2025 at 05:18:42PM +0000, Alexei Starovoitov wrote: > > > > On Tue, Feb 4, 2025 at 12:10 AM Charlie Jenkins wrote: > > > > > > > > > > The quiet infrastructure was moved out of Makefile.build to accomidate > > > > > the new syscall table generation scripts in perf. Syscall table > > > > > generation wanted to also be able to be quiet, so instead of again > > > > > copying the code to set the quiet variables, the code was moved into > > > > > Makefile.perf to be used globally. This was not the right solution. It > > > > > should have been moved even further upwards in the call chain. > > > > > Makefile.include is imported in many files so this seems like a proper > > > > > place to put it. > > > > > > > > > > To: > > > > > > > > > > Signed-off-by: Charlie Jenkins > > > > > --- > > > > > Charlie Jenkins (2): > > > > > tools: Unify top-level quiet infrastructure > > > > > tools: Remove redundant quiet setup > > > > > > > > > > tools/arch/arm64/tools/Makefile | 6 ----- > > > > > tools/bpf/Makefile | 6 ----- > > > > > tools/bpf/bpftool/Documentation/Makefile | 6 ----- > > > > > tools/bpf/bpftool/Makefile | 6 ----- > > > > > tools/bpf/resolve_btfids/Makefile | 2 -- > > > > > tools/bpf/runqslower/Makefile | 5 +--- > > > > > tools/build/Makefile | 8 +----- > > > > > tools/lib/bpf/Makefile | 13 ---------- > > > > > > > > Nack. > > > > libbpf and bpftool are synced independently to github > > > > and released from there. > > > > This change breaks it. > > > > Sorry, I overlooked this part and merged a change that touched the > > common files into the perf tree. > > > > f2868b1a66d4f40f ("perf tools: Expose quiet/verbose variables in Makefile.perf") > > > > Unfortunately, it's already in v6.14-rc1. > > > > > > > > Can you explain how it breaks it? Currently bpftool and resolve_btfids > > > don't build quietly so this was an attempt to fix that. > > > > So I think you will need something like this for v6.14. Again, sorry > > about the trouble. > > Just revert f2868b1a66d4f40f that created this mess. Why are you opposed to unifying this helpers among the various projects in tools? Can you explain what about this breaks the Github syncing flow and why it cannot be resolved? It doesn't make sense to duplicate "Q=" in every Makefile anybody ever wants to add to tools just because bpf syncing isn't robust. - Charlie