From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>, guoren <guoren@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Bibo Mao" <maobibo@loongson.cn>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Howard Chu" <howardchu95@gmail.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
linux-riscv@lists.infradead.org, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v4 01/11] perf dso: Move libunwind dso_data variables into ifdef
Date: Wed, 5 Mar 2025 14:52:56 -0300 [thread overview]
Message-ID: <Z8iPeEbldTUqotsQ@x1> (raw)
In-Reply-To: <20250304050305.901167-2-irogers@google.com>
On Mon, Mar 03, 2025 at 09:02:55PM -0800, Ian Rogers wrote:
> The variables elf_base_addr, debug_frame_offset, eh_frame_hdr_addr and
> eh_frame_hdr_offset are only accessed in unwind-libunwind-local.c
> which is conditionally built on having libunwind support. Make the
> variables conditional on libunwind support too.
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/dso.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
> index bb8e8f444054..dfd763a0bd9d 100644
> --- a/tools/perf/util/dso.h
> +++ b/tools/perf/util/dso.h
> @@ -154,10 +154,12 @@ struct dso_data {
> int status;
> u32 status_seen;
> u64 file_size;
> +#ifdef HAVE_LIBUNWIND_SUPPORT
> u64 elf_base_addr;
> u64 debug_frame_offset;
> u64 eh_frame_hdr_addr;
> u64 eh_frame_hdr_offset;
> +#endif
> };
>
> struct dso_bpf_prog {
> --
> 2.48.1.711.g2feabab25a-goog
next prev parent reply other threads:[~2025-03-05 17:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 5:02 [PATCH v4 00/11] perf: Support multiple system call tables in the build Ian Rogers
2025-03-04 5:02 ` [PATCH v4 01/11] perf dso: Move libunwind dso_data variables into ifdef Ian Rogers
2025-03-05 17:52 ` Arnaldo Carvalho de Melo [this message]
2025-03-04 5:02 ` [PATCH v4 02/11] perf dso: kernel-doc for enum dso_binary_type Ian Rogers
2025-03-05 17:54 ` Arnaldo Carvalho de Melo
2025-03-07 1:14 ` Namhyung Kim
2025-03-04 5:02 ` [PATCH v4 03/11] perf syscalltbl: Remove syscall_table.h Ian Rogers
2025-03-04 5:02 ` [PATCH v4 04/11] perf trace: Reorganize syscalls Ian Rogers
2025-03-04 5:02 ` [PATCH v4 05/11] perf syscalltbl: Remove struct syscalltbl Ian Rogers
2025-03-04 5:03 ` [PATCH v4 06/11] perf dso: Add support for reading the e_machine type for a dso Ian Rogers
2025-03-07 1:22 ` Namhyung Kim
2025-03-07 5:30 ` Ian Rogers
2025-03-04 5:03 ` [PATCH v4 07/11] perf thread: Add support for reading the e_machine type for a thread Ian Rogers
2025-03-04 5:03 ` [PATCH v4 08/11] perf trace beauty: Add syscalltbl.sh generating all system call tables Ian Rogers
2025-03-04 5:03 ` [PATCH v4 09/11] perf syscalltbl: Use lookup table containing multiple architectures Ian Rogers
2025-03-04 5:03 ` [PATCH v4 10/11] perf build: Remove Makefile.syscalls Ian Rogers
2025-03-04 5:03 ` [PATCH v4 11/11] perf syscalltbl: Mask off ABI type for MIPS system calls Ian Rogers
2025-03-04 7:04 ` [PATCH v4 00/11] perf: Support multiple system call tables in the build Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8iPeEbldTUqotsQ@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bjorn@rivosinc.com \
--cc=catalin.marinas@arm.com \
--cc=charlie@rivosinc.com \
--cc=chenhuacai@kernel.org \
--cc=guoren@kernel.org \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jirislaby@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maobibo@loongson.cn \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).