Re: [PATCH 0/6] perf: Deadcode - the P's

["Dr. David Alan Gilbert" <linux@treblig.org>]

* Ian Rogers (irogers@google.com) wrote:
> On Tue, Mar 4, 2025 at 6:32 PM <linux@treblig.org> wrote:

Hi Ian,
  Thanks for the review,

> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Hi,
> >   This is another set of perf deadcode, this is my set
> > all starting with 'p'.  It was built on top of
> > perf-tools-next as of a few days ago (7788ad59d1d9).
> >
> > Dave
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> >
> >
> >
> > Dr. David Alan Gilbert (6):
> >   perf core: Remove perf_event_attrs and perf_event_refresh
> 
> This will need to go into tip.git.

OK, do I need to split that out of the series, resend or do
anything else?

> >   perf util: Remove unused perf_color_default_config
> >   perf util: Remove unused pstack__pop
> >   perf util: Remove unused perf_data__update_dir
> >   perf util: Remove unused perf_pmus__default_pmu_name
> >   perf util: Remove unused perf_config__refresh
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,

Dave

> 
> Thanks,
> Ian
> 
> >  include/linux/perf_event.h     | 10 ----------
> >  kernel/events/core.c           | 24 ------------------------
> >  tools/perf/util/color.h        |  5 -----
> >  tools/perf/util/color_config.c | 11 -----------
> >  tools/perf/util/config.c       |  6 ------
> >  tools/perf/util/config.h       |  1 -
> >  tools/perf/util/data.c         | 20 --------------------
> >  tools/perf/util/data.h         |  1 -
> >  tools/perf/util/pmus.c         | 29 -----------------------------
> >  tools/perf/util/pmus.h         |  1 -
> >  tools/perf/util/pstack.c       | 14 --------------
> >  tools/perf/util/pstack.h       |  1 -
> >  12 files changed, 123 deletions(-)
> >
> > --
> > 2.48.1
> >
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/