From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B9A17579; Fri, 14 Mar 2025 17:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741972259; cv=none; b=ZxPLBWDENafmIldWAHhzdyXAIKJyKCpKncpvA/gJEYIpukqrfgrPtQhx8zZf8I7FCOY9U4KNNLf82VY35XdcXxCFSlWkDm2t1Vhhvh8boH29gpygPh+VOeAXJPbTTKDeTtCBZE6cbfjD/vA6zBrTYHIXArUl+hCazbYAnT3T0Fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741972259; c=relaxed/simple; bh=3qP/K6PXaEbNCIbhWyqtBndfXRD1PmrR9u5qWPtx+EM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nYLu7/LDfjwzpfrv0nHoY6Q+CqnVoH0Lwii0ntjWXwBGramnatUH+muFGhcrIv36DEZ16I+D++i7zY7UHmhSDUyHrZyFLcGn0/BWKMKYnRXZTzGS01ayR/G0pp4WhgoDF1eFOdSukY+A63kGnGqU8QI8CSZ0RTaMVcsZYF7s6Zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i5KAdulO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i5KAdulO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A66C3C4CEE3; Fri, 14 Mar 2025 17:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741972257; bh=3qP/K6PXaEbNCIbhWyqtBndfXRD1PmrR9u5qWPtx+EM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i5KAdulOYgMy3ouEcbFDhjjRmX2PTm/c5kxpGiIgEd9iHVllcNGqlGQAuz2n+X2+R sD4Cz79U3Tu9xoURi0jxEuxYMt6N5HISh5IItBwW8auateSihlVnVhJ4zWCnVpQpsm /t5KrbTGd8fE1jGsk/7YGBtAsjJED9o3CeNUBNEdjQUKDF5D3f7Vq7RzcSYGQd/mFQ wcknwDegn3KZIBWPhoWw+vrP2+h8q+PoCv3uGwN2jZ5fzX+oBMP6Tvhmk2R/+7h4Bf b3CyO4xiflCXNnrTFlRdJ+lMat42gpOwSJsRMkUfQVTvknoX0VvTmCes5t+v0XOx6n O4cpFlPMbldSw== Date: Fri, 14 Mar 2025 14:10:54 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , guoren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Charlie Jenkins , Bibo Mao , Huacai Chen , Catalin Marinas , Jiri Slaby , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Howard Chu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-csky@vger.kernel.org" , linux-riscv@lists.infradead.org, Arnd Bergmann Subject: Re: [PATCH v5 00/11] perf: Support multiple system call tables in the build Message-ID: References: <20250308003209.234114-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 13, 2025 at 10:45:49PM -0700, Namhyung Kim wrote: > On Thu, Mar 13, 2025 at 05:47:27PM -0300, Arnaldo Carvalho de Melo wrote: > > On Thu, Mar 13, 2025 at 05:20:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > Still building, but noticed this on x86_64: > > > > > > 105: perf trace enum augmentation tests : FAILED! > > > 106: perf trace BTF general tests : FAILED! > > > 107: perf trace exit race : Ok > > > 108: perf trace record and replay : FAILED! > > > > > > > > > The first doesn´t help that much with verbose mode, haven't checked if > > > before this series it was failing :-\ > > > > > > root@x1:~# perf test -vvv 105 > > > 105: perf trace enum augmentation tests: > > > --- start --- > > > test child forked, pid 19411 > > > Checking if vmlinux exists > > > Tracing syscall landlock_add_rule > > > ---- end(-1) ---- > > > 105: perf trace enum augmentation tests : FAILED! > > > root@x1:~# > > > > So: > > > > root@x1:~# perf trace -e landlock_add_rule perf test -w landlock > > root@x1:~# > > > > But: > > > > root@x1:~# perf trace perf test -w landlock |& grep landlock_add_rule > > 26.120 ( 0.002 ms): perf/19791 landlock_add_rule(ruleset_fd: 11, rule_type: LANDLOCK_RULE_PATH_BENEATH, rule_attr: 0x7ffde75e2680, flags: 45) = -1 EINVAL (Invalid argument) > > 26.124 ( 0.001 ms): perf/19791 landlock_add_rule(ruleset_fd: 11, rule_type: LANDLOCK_RULE_NET_PORT, rule_attr: 0x7ffde75e2690, flags: 45) = -1 EINVAL (Invalid argument) > > root@x1:~# > > > > -e is having some trouble, when no event is specified, then it works. > > > > Something in the changes made to: > > > > static int trace__parse_events_option(const struct option *opt, const char *str, > > int unset __maybe_unused) > > Thanks for the test, I think this should fix it: > Well, not really: root@number:~# perf trace -e landlock_add_rule perf test -w landlock perf: Segmentation fault Obtained 10 stack frames. perf() [0x5be761] perf() [0x5be7f9] /lib64/libc.so.6(+0x40fd0) [0x7fe005c4efd0] perf() [0x491bc1] perf() [0x497090] perf() [0x4973ab] perf() [0x413483] /lib64/libc.so.6(+0x2a088) [0x7fe005c38088] /lib64/libc.so.6(__libc_start_main+0x8b) [0x7fe005c3814b] perf() [0x413ad5] Segmentation fault (core dumped) root@number:~# Time for me to test another patch from Ian, the one symbolizing the above backtrace... - Arnaldo > > > ---8<--- > diff --git a/tools/perf/util/syscalltbl.c b/tools/perf/util/syscalltbl.c > index ace66e69c1bcde1e..67a8ec10e9e4bc8d 100644 > --- a/tools/perf/util/syscalltbl.c > +++ b/tools/perf/util/syscalltbl.c > @@ -76,7 +76,7 @@ int syscalltbl__id(int e_machine, const char *name) > { > const struct syscalltbl *table = find_table(e_machine); > struct syscall_cmp_key key; > - const int *id; > + const uint16_t *id; > > if (!table) > return -1;