From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D498C678D4 for ; Thu, 2 Mar 2023 14:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjCBOfA (ORCPT ); Thu, 2 Mar 2023 09:35:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbjCBOe7 (ORCPT ); Thu, 2 Mar 2023 09:34:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 837DD1284B; Thu, 2 Mar 2023 06:34:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E7D5615D2; Thu, 2 Mar 2023 14:34:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 445C1C433EF; Thu, 2 Mar 2023 14:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677767677; bh=am2Pms4fC7Mb/X3wlNdEKvPjV1B08gkpE6ryQz2S3CI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HQUUGL8ZdCd64toSBpMY2gXtz8rhPG6UFK7zTU8cYXcH9s9YF+v4BXfjWioHvIX1E uOm+1ZHKl86gMFbEWwIB7ACztp+OTESh4ehQQVJG9RcJr65CTfd1ABjn/Klj6w9caa 8b8KNS+NR/tGSqOLFz4cSZCLB7x1JIq/TFei3K/fG1hTR9zqKgUmUOh3Xqy5WN/Vrs WMW9KESdw1YHg4yAED+v9myP13HpO5kMW71zHMwCW7Hhu2qDodrMREWiXKivR1YnIg uwdY4n8xVNNQHmeALGTBPBdgjtnQQQq4KYCRbXF7MkukijPVdfB+j+BRb9HkdN5/Gj irAaQ8DOAEB2A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5111E4049F; Thu, 2 Mar 2023 11:34:35 -0300 (-03) Date: Thu, 2 Mar 2023 11:34:35 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Zhengjun Xing , Ravi Bangoria , Adrian Hunter , "Steinar H. Gunderson" , Qi Liu , Kim Phillips , Florian Fischer , James Clark , Suzuki Poulouse , Sean Christopherson , Leo Yan , John Garry , Kajol Jain , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v1 04/10] perf stat: Modify the group test Message-ID: References: <20230302041211.852330-1-irogers@google.com> <20230302041211.852330-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230302041211.852330-5-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Mar 01, 2023 at 08:12:05PM -0800, Ian Rogers escreveu: > Previously nr_members would be 0 for an event with no group. The > previous change made that count 1, the event is its own leader without > a group. Make the find_stat logic consistent with this, an improvement > suggested by Namhyung Kim. Is this the only place where this change in behaviour needs to be taken into account? - Arnaldo > Suggested-by: Namhyung Kim > Signed-off-by: Ian Rogers > --- > tools/perf/util/stat-shadow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > index ef85f1ae1ab2..eeccab6751d7 100644 > --- a/tools/perf/util/stat-shadow.c > +++ b/tools/perf/util/stat-shadow.c > @@ -163,7 +163,7 @@ static double find_stat(const struct evsel *evsel, int aggr_idx, enum stat_type > continue; > > /* Ignore evsels that are part of different groups. */ > - if (evsel->core.leader->nr_members && > + if (evsel->core.leader->nr_members > 1 && > evsel->core.leader != cur->core.leader) > continue; > /* Ignore evsels with mismatched modifiers. */ > -- > 2.39.2.722.g9855ee24e9-goog > -- - Arnaldo