From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com,
will@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, gankulkarni@os.amperecomputing.com,
darren@os.amperecomputing.com
Subject: Re: [PATCH v9 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID
Date: Fri, 31 Mar 2023 08:51:45 -0300 [thread overview]
Message-ID: <ZCbJUWw7TkUCWWuc@kernel.org> (raw)
In-Reply-To: <20230331055645.26918-1-mike.leach@linaro.org>
Em Fri, Mar 31, 2023 at 06:56:42AM +0100, Mike Leach escreveu:
> The original method for allocating trace source ID values to sources was
> to use a fixed algorithm for CPU based sources of (cpu_num * 2 + 0x10).
> The STM was allocated ID 0x1.
>
> This mechanism is broken for systems with more than 47 cores.
>
> The kernel related patches the provide a fixed Trace ID allocation mechanism
> are now upstreamed.
>
> This patchset updates the perf code to handle the changes to the trace ID
> notification mechanism that now uses the PERF_RECORD_AUX_OUTPUT_HW_ID
> packet to set Trace ID in the perf ETM decoders.
>
> Applies and test oo perf/core
I'm keeping perf/core with the same contents as perf-tools-next, please
use perf-tools-next as in the future I'll stop using the old perf/core
name.
Applied, testing.
- Arnaldo
> Changes since v8:
> 1. Fix build issues
> 2. Fix implicit function problem
>
> Changes since v7:
> Split from original patchset [1] to be sent separately as kernel related
> patches are now upstream.
>
> [1] https://lore.kernel.org/linux-arm-kernel/20230116124928.5440-1-mike.leach@linaro.org/
>
> Mike Leach (3):
> perf: cs-etm: Move mapping of Trace ID and cpu into helper function
> perf: cs-etm: Update record event to use new Trace ID protocol
> perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet
>
> tools/include/linux/coresight-pmu.h | 47 ++-
> tools/perf/arch/arm/util/cs-etm.c | 27 +-
> tools/perf/util/cs-etm-base.c | 3 +-
> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 7 +
> tools/perf/util/cs-etm.c | 326 +++++++++++++++---
> tools/perf/util/cs-etm.h | 14 +-
> 6 files changed, 356 insertions(+), 68 deletions(-)
>
> --
> 2.17.1
>
--
- Arnaldo
prev parent reply other threads:[~2023-03-31 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 5:56 [PATCH v9 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Mike Leach
2023-03-31 5:56 ` [PATCH v9 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach
2023-03-31 5:56 ` [PATCH v9 2/3] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach
2023-03-31 5:56 ` [PATCH v9 3/3] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach
2023-03-31 11:51 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCbJUWw7TkUCWWuc@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=darren@os.amperecomputing.com \
--cc=gankulkarni@os.amperecomputing.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).