* [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar
@ 2023-01-14 13:05 Alexander Pantyukhin
2023-01-16 5:15 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Pantyukhin @ 2023-01-14 13:05 UTC (permalink / raw)
To: adrian.hunter
Cc: mingo, namhyung, jolsa, acme, akpm, linux-perf-users,
linux-kernel, Alexander Pantyukhin
The event_attr is never used later, the var is ok be deleted.
Additional code simplification is to substitute string slice comparison
with "substring" function. This case no need to know the length specific
words.
Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com>
---
tools/perf/scripts/python/intel-pt-events.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
index 08862a2582f4..dfd566369ca4 100644
--- a/tools/perf/scripts/python/intel-pt-events.py
+++ b/tools/perf/scripts/python/intel-pt-events.py
@@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn):
print(start_str, src_str)
def do_process_event(param_dict):
- event_attr = param_dict["attr"]
sample = param_dict["sample"]
raw_buf = param_dict["raw_buf"]
comm = param_dict["comm"]
@@ -349,6 +348,7 @@ def do_process_event(param_dict):
# callchain = param_dict["callchain"]
# brstack = param_dict["brstack"]
# brstacksym = param_dict["brstacksym"]
+ # event_attr = param_dict["attr"]
# Symbol and dso info are not always resolved
dso = get_optional(param_dict, "dso")
@@ -359,13 +359,13 @@ def do_process_event(param_dict):
print(glb_switch_str[cpu])
del glb_switch_str[cpu]
- if name[0:12] == "instructions":
+ if name.startswith("instructions"):
if glb_src:
print_srccode(comm, param_dict, sample, symbol, dso, True)
else:
print_instructions_start(comm, sample)
print_common_ip(param_dict, sample, symbol, dso)
- elif name[0:8] == "branches":
+ elif name.startswith("branches"):
if glb_src:
print_srccode(comm, param_dict, sample, symbol, dso, False)
else:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar
2023-01-14 13:05 [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar Alexander Pantyukhin
@ 2023-01-16 5:15 ` Adrian Hunter
2023-04-12 15:20 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2023-01-16 5:15 UTC (permalink / raw)
To: Alexander Pantyukhin
Cc: mingo, namhyung, jolsa, acme, akpm, linux-perf-users,
linux-kernel
On 14/01/23 15:05, Alexander Pantyukhin wrote:
> The event_attr is never used later, the var is ok be deleted.
> Additional code simplification is to substitute string slice comparison
> with "substring" function. This case no need to know the length specific
> words.
>
> Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/scripts/python/intel-pt-events.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
> index 08862a2582f4..dfd566369ca4 100644
> --- a/tools/perf/scripts/python/intel-pt-events.py
> +++ b/tools/perf/scripts/python/intel-pt-events.py
> @@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn):
> print(start_str, src_str)
>
> def do_process_event(param_dict):
> - event_attr = param_dict["attr"]
> sample = param_dict["sample"]
> raw_buf = param_dict["raw_buf"]
> comm = param_dict["comm"]
> @@ -349,6 +348,7 @@ def do_process_event(param_dict):
> # callchain = param_dict["callchain"]
> # brstack = param_dict["brstack"]
> # brstacksym = param_dict["brstacksym"]
> + # event_attr = param_dict["attr"]
>
> # Symbol and dso info are not always resolved
> dso = get_optional(param_dict, "dso")
> @@ -359,13 +359,13 @@ def do_process_event(param_dict):
> print(glb_switch_str[cpu])
> del glb_switch_str[cpu]
>
> - if name[0:12] == "instructions":
> + if name.startswith("instructions"):
> if glb_src:
> print_srccode(comm, param_dict, sample, symbol, dso, True)
> else:
> print_instructions_start(comm, sample)
> print_common_ip(param_dict, sample, symbol, dso)
> - elif name[0:8] == "branches":
> + elif name.startswith("branches"):
> if glb_src:
> print_srccode(comm, param_dict, sample, symbol, dso, False)
> else:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar
2023-01-16 5:15 ` Adrian Hunter
@ 2023-04-12 15:20 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-04-12 15:20 UTC (permalink / raw)
To: Adrian Hunter
Cc: Alexander Pantyukhin, mingo, namhyung, jolsa, akpm,
linux-perf-users, linux-kernel
Em Mon, Jan 16, 2023 at 07:15:01AM +0200, Adrian Hunter escreveu:
> On 14/01/23 15:05, Alexander Pantyukhin wrote:
> > The event_attr is never used later, the var is ok be deleted.
> > Additional code simplification is to substitute string slice comparison
> > with "substring" function. This case no need to know the length specific
> > words.
> >
> > Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Finally picked this one,
- Arnaldo
> > ---
> > tools/perf/scripts/python/intel-pt-events.py | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
> > index 08862a2582f4..dfd566369ca4 100644
> > --- a/tools/perf/scripts/python/intel-pt-events.py
> > +++ b/tools/perf/scripts/python/intel-pt-events.py
> > @@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn):
> > print(start_str, src_str)
> >
> > def do_process_event(param_dict):
> > - event_attr = param_dict["attr"]
> > sample = param_dict["sample"]
> > raw_buf = param_dict["raw_buf"]
> > comm = param_dict["comm"]
> > @@ -349,6 +348,7 @@ def do_process_event(param_dict):
> > # callchain = param_dict["callchain"]
> > # brstack = param_dict["brstack"]
> > # brstacksym = param_dict["brstacksym"]
> > + # event_attr = param_dict["attr"]
> >
> > # Symbol and dso info are not always resolved
> > dso = get_optional(param_dict, "dso")
> > @@ -359,13 +359,13 @@ def do_process_event(param_dict):
> > print(glb_switch_str[cpu])
> > del glb_switch_str[cpu]
> >
> > - if name[0:12] == "instructions":
> > + if name.startswith("instructions"):
> > if glb_src:
> > print_srccode(comm, param_dict, sample, symbol, dso, True)
> > else:
> > print_instructions_start(comm, sample)
> > print_common_ip(param_dict, sample, symbol, dso)
> > - elif name[0:8] == "branches":
> > + elif name.startswith("branches"):
> > if glb_src:
> > print_srccode(comm, param_dict, sample, symbol, dso, False)
> > else:
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 13:05 [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar Alexander Pantyukhin
2023-01-16 5:15 ` Adrian Hunter
2023-04-12 15:20 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).