From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] libperf rc_check: Enable implicitly with sanitizers
Date: Thu, 20 Apr 2023 15:12:52 -0300 [thread overview]
Message-ID: <ZEGApFbdz44z9GeX@kernel.org> (raw)
In-Reply-To: <20230420171812.561603-1-irogers@google.com>
Em Thu, Apr 20, 2023 at 10:18:12AM -0700, Ian Rogers escreveu:
> If using leak sanitizer then implicitly enable reference count
> checking.
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/lib/perf/include/internal/rc_check.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/lib/perf/include/internal/rc_check.h b/tools/lib/perf/include/internal/rc_check.h
> index c0626d8beb59..d5d771ccdc7b 100644
> --- a/tools/lib/perf/include/internal/rc_check.h
> +++ b/tools/lib/perf/include/internal/rc_check.h
> @@ -5,6 +5,14 @@
> #include <stdlib.h>
> #include <linux/zalloc.h>
>
> +/*
> + * Enable reference count checking implicitly with leak checking, which is
> + * integrated into address sanitizer.
> + */
> +#if defined(LEAK_SANITIZER) || defined(ADDRESS_SANITIZER)
> +#define REFCNT_CHECKING 1
> +#endif
> +
> /*
> * Shared reference count checking macros.
> *
> --
> 2.40.0.634.g4ca3ef3211-goog
>
--
- Arnaldo
prev parent reply other threads:[~2023-04-20 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 17:18 [PATCH v1] libperf rc_check: Enable implicitly with sanitizers Ian Rogers
2023-04-20 18:12 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEGApFbdz44z9GeX@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).