From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375D9C77B61 for ; Sat, 29 Apr 2023 01:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347078AbjD2BU0 (ORCPT ); Fri, 28 Apr 2023 21:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347049AbjD2BUZ (ORCPT ); Fri, 28 Apr 2023 21:20:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 538DA2703; Fri, 28 Apr 2023 18:20:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C825963EBB; Sat, 29 Apr 2023 01:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02B3AC433D2; Sat, 29 Apr 2023 01:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682731223; bh=cXEGEEEjMxbFbsEVKrFzprQpsYPuj0Im0jVmqU+ky8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gf6hQXOsmuRCR+NLHGaOlXpluylAcEdO15qBnEFTfaXM49L4WQIQ3EmK3I+8UzYM6 snhSBPSGClVOEZQE6OmsZzSGPw66xEko3t2O16gs9VtEV7qEByYeFOkaU9XcEA3oi8 /tt9S/VV3gQYr5QVWvL+ADILOBJmpgbTnL+B2UTO31D6oHdywRKsssLo0loHPirWRu GhSBb2PO0S+5w6Rf32lJuwYZ22gbkuGZF+cvFzVLko3a4fb/PUVFfxRM3K8pQqD62d NT8BpS8ILOEX0Sst091w7+kH2a7SzssLH0yd9GtvB8bconb//2px+IxoAFINTfXz16 YKCKwIOzGWgxA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B3C4E403B5; Fri, 28 Apr 2023 22:20:20 -0300 (-03) Date: Fri, 28 Apr 2023 22:20:20 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Kan Liang , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/43] perf stat: Avoid segv on counter->name Message-ID: References: <20230428073809.1803624-1-irogers@google.com> <20230428073809.1803624-10-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230428073809.1803624-10-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Apr 28, 2023 at 12:37:35AM -0700, Ian Rogers escreveu: > Switch to use evsel__name that doesn't return NULL for hardware and > similar events. > > Reviewed-by: Kan Liang > Signed-off-by: Ian Rogers Thanks, applied. - Arnaldo > --- > tools/perf/util/stat-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index df6337f2480b..7aa7e16fa7c4 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -748,7 +748,7 @@ static void uniquify_event_name(struct evsel *counter) > int ret = 0; > > if (counter->uniquified_name || counter->use_config_name || > - !counter->pmu_name || !strncmp(counter->name, counter->pmu_name, > + !counter->pmu_name || !strncmp(evsel__name(counter), counter->pmu_name, > strlen(counter->pmu_name))) > return; > > -- > 2.40.1.495.gc816e09b53d-goog > -- - Arnaldo