From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFB2C77B61 for ; Sat, 29 Apr 2023 01:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347128AbjD2BRO (ORCPT ); Fri, 28 Apr 2023 21:17:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbjD2BRN (ORCPT ); Fri, 28 Apr 2023 21:17:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 323E226A2; Fri, 28 Apr 2023 18:17:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7836D62DA9; Sat, 29 Apr 2023 01:17:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ED16C433D2; Sat, 29 Apr 2023 01:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682731030; bh=O25C2lf3JDsYzim7XaruprOx13noBC1kpWMv0pf/5hA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e7TiSeB52VMbWxv6Q/ov1aH+L66g7MhYnJGg7IsEHqrG2pRd9rs6692XATOQRJfXx f6EDpvD3Kefj+XN4/PaSYr/WiJFe58xiBLRDY75CnHBTbE+cJmjv5Q+XkornnKFpu+ uq8jQHycOHbSoreFogGlbVygmKYpGIN+O81UBJla732JiAujXBcMEASU9Bf1cjg/po EskcpMdFDiSgcQzulhRC54ZjUofgsUki8PTW3HRFbd3rBpvCYN3EiYljNgtzXr9Oo+ DDAuPnIS8QYiH7+SLVkPCzX3+kFbST+E+GCliylhQyZQgNTgkyoByQLG4rJruQoDtN 8hB+fdpQruGSg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1BEFC403B5; Fri, 28 Apr 2023 22:17:08 -0300 (-03) Date: Fri, 28 Apr 2023 22:17:08 -0300 From: Arnaldo Carvalho de Melo To: "Liang, Kan" Cc: Ian Rogers , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/43] perf stat: Disable TopdownL1 on hybrid Message-ID: References: <20230428073809.1803624-1-irogers@google.com> <20230428073809.1803624-2-irogers@google.com> <920c682a-3789-51fb-805e-4561c85f4219@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <920c682a-3789-51fb-805e-4561c85f4219@linux.intel.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Apr 28, 2023 at 09:31:30AM -0400, Liang, Kan escreveu: > > > On 2023-04-28 3:37 a.m., Ian Rogers wrote: > > Bugs with event parsing, event grouping and metrics causes the > > TopdownL1 metricgroup to crash the perf command. Temporarily disable > > the group if no events/metrics are spcecified. > > > > I think it's OK to only disable the metric for perf stat default > temporarily on hybrid as a workaround for 6.4. > Now, the only problem is the default of perf stat on pre-icl in 6.4. > > > Signed-off-by: Ian Rogers > > Reviewed-by: Kan Liang > > Arnaldo, could you please back port this for 6.4 as well? Sure, picking this one now > Thanks, > Kan > > --- > > tools/perf/builtin-stat.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > > index efda63f6bf32..be9677aa642f 100644 > > --- a/tools/perf/builtin-stat.c > > +++ b/tools/perf/builtin-stat.c > > @@ -1885,7 +1885,12 @@ static int add_default_attributes(void) > > * Add TopdownL1 metrics if they exist. To minimize > > * multiplexing, don't request threshold computation. > > */ > > - if (metricgroup__has_metric("TopdownL1") && > > + /* > > + * TODO: TopdownL1 is disabled on hybrid CPUs to avoid a crashes > > + * caused by exposing latent bugs. This is fixed properly in: > > + * https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/ > > + */ > > + if (metricgroup__has_metric("TopdownL1") && !perf_pmu__has_hybrid() && > > metricgroup__parse_groups(evsel_list, "TopdownL1", > > /*metric_no_group=*/false, > > /*metric_no_merge=*/false, > > @@ -1894,6 +1899,7 @@ static int add_default_attributes(void) > > stat_config.system_wide, > > &stat_config.metric_events) < 0) > > return -1; > > + > > /* Platform specific attrs */ > > if (evlist__add_default_attrs(evsel_list, default_null_attrs) < 0) > > return -1; -- - Arnaldo