From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD377C7EE22 for ; Thu, 11 May 2023 10:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237327AbjEKKJe (ORCPT ); Thu, 11 May 2023 06:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbjEKKJc (ORCPT ); Thu, 11 May 2023 06:09:32 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88CCA7D85; Thu, 11 May 2023 03:09:29 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 0B8EF21A7A; Thu, 11 May 2023 10:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683799768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SbrhlAxTy12DuOMU4fjS/AymAGt4r/nQ5uvoi576oXM=; b=VAUBVXxcOYrdWYrOPvR6B8qg753tmtNfI5oh7SL8GWP9gCw0aTtROJHDE8kWmh+b1nFuKu C6IZngtzdwZjZhkrt4EyTwF+Z+vfmDTwEWo5LzOjQE1ptpqObMqhXokJERk5TNsjOb/xyc 9Erw3Fcbne9jc8AZ14Njgrl3nfmsYoE= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id CCAF52C141; Thu, 11 May 2023 10:09:25 +0000 (UTC) Date: Thu, 11 May 2023 12:09:24 +0200 From: Petr Mladek To: Douglas Anderson Cc: Andrew Morton , Sumit Garg , Mark Rutland , Matthias Kaehlcke , Stephane Eranian , Stephen Boyd , ricardo.neri@intel.com, Tzung-Bi Shih , Lecopzer Chen , kgdb-bugreport@lists.sourceforge.net, Masayoshi Mizuma , Guenter Roeck , Pingfan Liu , Andi Kleen , Ian Rogers , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com, Randy Dunlap , Chen-Yu Tsai , christophe.leroy@csgroup.eu, davem@davemloft.net, sparclinux@vger.kernel.org, mpe@ellerman.id.au, Will Deacon , ravi.v.shankar@intel.com, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, Marc Zyngier , Catalin Marinas , Daniel Thompson Subject: Re: [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c Message-ID: References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu 2023-05-04 15:13:38, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy hardlockup detector, > which doesn't use perf. > > It could be argued that the new name makes it less obvious that this > is a hardlockup detector. While true, it's not hard to remember that > the "perf" detector is always a hardlockup detector and it's nice not > to have names that are too convoluted. > > Signed-off-by: Douglas Anderson Looks good: Reviewed-by: Petr Mladek Best Regards, Petr