From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E21C7EE23 for ; Mon, 5 Jun 2023 14:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233895AbjFEObm (ORCPT ); Mon, 5 Jun 2023 10:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbjFEObl (ORCPT ); Mon, 5 Jun 2023 10:31:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79D85E9; Mon, 5 Jun 2023 07:31:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C1A462077; Mon, 5 Jun 2023 14:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3745BC4339B; Mon, 5 Jun 2023 14:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685975499; bh=mrOtizINhh5fwcPJizUYE/rj2XWhdL1zZyiYvybGQy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipUDWWw91EH6WtuSoZK4XL6EcAt2gTqwhl+h3IOz3di7bYV00b/T/zOXk/p4Ju31h c4AdttDWyfVpNILj2dEM9x3F7vusCqfB7bxt/TejnJmyRkzif3EKIcXYl54VxmHKL8 bQiIp0oLAoAsQVlNh2rbhqLTeLSXShn6is1Y2aaewZav/zEEUisL9ZxpxYm6KzuPVJ oh7IxDtgC1Xse94PiLhzHr2teO1eAlow7zSV9NbMbL10lLxSL83SE87Fqm3WEwOYqE 2bUuLcFRAC1Mqxbx77lvECE55OK9AO+2snJL279hxAz51Aai6EevkbrgBQ0HmrEy2Q F0pvcXDa5IP7w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E3B0240692; Mon, 5 Jun 2023 11:31:36 -0300 (-03) Date: Mon, 5 Jun 2023 11:31:36 -0300 From: Arnaldo Carvalho de Melo To: Alexandre Ghiti Cc: Andrew Jones , Jonathan Corbet , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Rob Herring , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 10/10] perf: tests: Adapt mmap-basic.c for riscv Message-ID: References: <20230512085321.13259-1-alexghiti@rivosinc.com> <20230512085321.13259-11-alexghiti@rivosinc.com> <20230531-31bd9ddeaca8cb338f81ed14@orel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Jun 05, 2023 at 04:00:12PM +0200, Alexandre Ghiti escreveu: > On Mon, Jun 5, 2023 at 3:53 PM Arnaldo Carvalho de Melo > wrote: > > > Em Wed, May 31, 2023 at 05:15:15PM +0200, Andrew Jones escreveu: > > > On Fri, May 12, 2023 at 10:53:21AM +0200, Alexandre Ghiti wrote: > > > > riscv now supports mmaping hardware counters to userspace so adapt the > > test > > > > to run on this architecture. > > > > > > > > Signed-off-by: Alexandre Ghiti > > > > --- > > > > tools/perf/tests/mmap-basic.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/tools/perf/tests/mmap-basic.c > > b/tools/perf/tests/mmap-basic.c > > > > index e68ca6229756..f5075ca774f8 100644 > > > > --- a/tools/perf/tests/mmap-basic.c > > > > +++ b/tools/perf/tests/mmap-basic.c > > > > @@ -284,7 +284,7 @@ static struct test_case tests__basic_mmap[] = { > > > > "permissions"), > > > > TEST_CASE_REASON("User space counter reading of instructions", > > > > mmap_user_read_instr, > > > > -#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) > > > > +#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) > > || __riscv_xlen == 64 > > > > "permissions" > > > > #else > > > > "unsupported" > > > > @@ -292,7 +292,7 @@ static struct test_case tests__basic_mmap[] = { > > > > ), > > > > TEST_CASE_REASON("User space counter reading of cycles", > > > > mmap_user_read_cycles, > > > > -#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) > > > > +#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) > > || __riscv_xlen == 64 > > > > "permissions" > > > > #else > > > > "unsupported" > > > > -- > > > > 2.37.2 > > > > > > > > > > Reviewed-by: Andrew Jones > > > > Was the kernel part merged upstream? > > > > No, I still haven't answered the reviews :) Ok, I'll then wait for it to happen to consider merging the userland parts, Thanks, - Arnaldo