From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B48C77B73 for ; Mon, 5 Jun 2023 19:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235772AbjFETo5 (ORCPT ); Mon, 5 Jun 2023 15:44:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235759AbjFETot (ORCPT ); Mon, 5 Jun 2023 15:44:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01FAEF1; Mon, 5 Jun 2023 12:44:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 85A88629E3; Mon, 5 Jun 2023 19:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF163C433EF; Mon, 5 Jun 2023 19:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685994287; bh=P3Zf9vDH5D/IWGkhQFjE1PM6fek60DSu9f7MDIGdx2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IDLgFf79qxTKEyrb4uMU2oWQtMOa+noftKfMZYlXF6dzY0osIBZaVgbt0vfERO0Ff vzTklZwU7pKPs/UWngEkue52KiS0GzoRlDU0G+rUli38ukb0hY9w4FHhd6dwn0tZSB 4m4i71zvazfIFNGh5cRiok0hNPMxUM6AuCNRXgwZq4oo+84SwjhKpwNICnVD5fvDyr BfE8JXejfya107VylZBmuo59x/yeO0DY+rpDHKGviRrsE6RKrQZyeib5mpLI7wAKXd AhUxmsFRpI9vfkaVkrWqGwW4u71n6YUPtxqCxxVfscQ1sREvBo+MEzzRK7jtH3FSkH K62I3FhF01ZuQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B09340692; Mon, 5 Jun 2023 16:44:45 -0300 (-03) Date: Mon, 5 Jun 2023 16:44:45 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: coresight@lists.linaro.org, denik@chromium.org, Suzuki K Poulose , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] perf cs-etm: Track exception level Message-ID: References: <20230524131958.2139331-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524131958.2139331-1-james.clark@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, May 24, 2023 at 02:19:54PM +0100, James Clark escreveu: > Some fixes to support an issue reported by Denis Nikitin where decoding > trace that contains different EL1 and EL2 kernels can crash or go into > an infinite loop because the wrong kernel maps are used for the decode. > > This still doesn't support distinguishing guest and host userspace, > we'd still have to fix the timestamps and do a bit more work to > correlate that. And I've removed PERF_RECORD_MISC_HYPERVISOR as a > possible outcome of cs_etm__cpu_mode(). As far as I know this could > never have been returned anyway because machine__is_host(machine) was > always true due to session.machines.host being hard coded. And I'm not > sure of the relevance of the difference between PERF_RECORD_MISC_KERNEL > and PERF_RECORD_MISC_HYPERVISOR in this scenario. > > The first commit is a tidy up, second fixes a bug that I found when > comparing the exception level and thread of branch records, the third > is the main fix, and the last commit is some extra error checking. > > Applies to acme/perf-tools (4e111f0cf0) So there seems to be agreement the first two patches can be applied? May I go ahead and do that now? - Arnaldo > James Clark (4): > perf cs-etm: Only track threads instead of PID and TIDs > perf cs-etm: Use previous thread for branch sample source IP > perf cs-etm: Track exception level > perf cs-etm: Add exception level consistency check > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 13 +- > .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 4 +- > tools/perf/util/cs-etm.c | 220 +++++++++--------- > tools/perf/util/cs-etm.h | 5 +- > 4 files changed, 126 insertions(+), 116 deletions(-) > > -- > 2.34.1 > -- - Arnaldo