From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CB4C77B7A for ; Tue, 30 May 2023 14:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbjE3OlD (ORCPT ); Tue, 30 May 2023 10:41:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230446AbjE3OlC (ORCPT ); Tue, 30 May 2023 10:41:02 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 847E4123; Tue, 30 May 2023 07:40:51 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 338C921A03; Tue, 30 May 2023 14:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1685457650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9sB6H+XW8Y7WjDvQjfVnkpXnUAqYkrBI6CEECBeZUA=; b=UGwjgMinTKp0NsJ7pZlarCt1OheuX6unt7XijzKaXk1mMO1rIPhdMjZBOd+sRPfBYEZTXf 3Exe5XXnF/9X9UqRSJdkgenu/x8GSb4mziBg7Ay1i9WhzKP/icDtGBDBRreSWdLf3bTTFp N5ljukBANN3f+Pmdgj1Dp+CwZ/3c4fs= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E44292C141; Tue, 30 May 2023 14:40:49 +0000 (UTC) Date: Tue, 30 May 2023 16:40:49 +0200 From: Petr Mladek To: Douglas Anderson Cc: Andrew Morton , kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, Nicholas Piggin , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , sparclinux@vger.kernel.org, "David S . Miller" , linux-perf-users@vger.kernel.org Subject: Re: [PATCH 04/10] watchdog/hardlockup: In watchdog_hardlockup_check() use cpumask_copy() Message-ID: References: <20230527014153.2793931-1-dianders@chromium.org> <20230526184139.4.Iccee2d1ea19114dafb6553a854ea4d8ab2a3f25b@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526184139.4.Iccee2d1ea19114dafb6553a854ea4d8ab2a3f25b@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri 2023-05-26 18:41:34, Douglas Anderson wrote: > In the patch ("watchdog/hardlockup: add a "cpu" param to > watchdog_hardlockup_check()") we started using a cpumask to keep track > of which CPUs to backtrace. When setting up this cpumask, it's better > to use cpumask_copy() than to just copy the structure directly. Fix this. > > Suggested-by: Petr Mladek > Signed-off-by: Douglas Anderson Reviewed-by: Petr Mladek Best Regards, Petr