From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562E7C77B7A for ; Wed, 7 Jun 2023 13:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240221AbjFGNsY (ORCPT ); Wed, 7 Jun 2023 09:48:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240459AbjFGNsW (ORCPT ); Wed, 7 Jun 2023 09:48:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04B5E1FC8; Wed, 7 Jun 2023 06:48:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62FE263F9C; Wed, 7 Jun 2023 13:48:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D9B8C4339E; Wed, 7 Jun 2023 13:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686145691; bh=wf2XVFNUEgH+dPenf4U/GenfgafdyccvlWF1Dp+rFHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l7XHq6YO7SuvCp5ZPMGFBBhOT0+DObP+Fft8vLFS/PJgrWhszhHbDuTgj+RpS3hNs s7m2gCGV4CAr4/2/dCtlj6ui4oURAdLGa+8o+NrzWywqX+Z3DZN9ZK1nWcyTS7NjzT CgkoaxXb3W1DQVvRwVbTbrAkkBgFZXAILcax2fazhBrgWdBZ2q8B4CGRt7qdRll2gM NvNtUyUYQ0KNWe4V5IsMJsJhoJGvNp2W/Tc0u5CveuYK7nP7D5F1/95reK+evbTRwM HrBMBpWzh/A9xSeXcXpuNNDijir1m2yTwU8LKaR9pXu/srfpYNxbmkvoqzuUCFi6Ta Eneaq0snhGMJg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1392D40692; Wed, 7 Jun 2023 10:48:09 -0300 (-03) Date: Wed, 7 Jun 2023 10:48:08 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints Message-ID: References: <20230525082902.25332-1-adrian.hunter@intel.com> <9a3776f9-9c9e-b23f-9f18-91b4b5b8364d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Jun 07, 2023 at 08:33:07AM +0300, Adrian Hunter escreveu: > Maybe this is cleaner: It is, I folded it into your original patch, thanks! - Arnaldo > > From: Adrian Hunter > Date: Wed, 7 Jun 2023 08:12:29 +0300 > Subject: [PATCH] perf tools: Suppress bison unused value warnings > > Patch "perf tools: Allow config terms with breakpoints" introduced > parse tokens for colons and slashes within breakpoint parsing to > prevent mix up with colons and slashes related to config terms. > > The token values are not needed but introduce bison "unused value" > warnings. > > Suppress those warnings. > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/parse-events.h | 4 ++++ > tools/perf/util/parse-events.y | 7 +++++++ > 2 files changed, 11 insertions(+) > > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h > index b0eb95f93e9c..5fdc1f33f57e 100644 > --- a/tools/perf/util/parse-events.h > +++ b/tools/perf/util/parse-events.h > @@ -228,6 +228,10 @@ void parse_events_error__handle(struct parse_events_error *err, int idx, > void parse_events_error__print(struct parse_events_error *err, > const char *event); > > +static inline void parse_events_unused_value(const void *x __maybe_unused) > +{ > +} > + > #ifdef HAVE_LIBELF_SUPPORT > /* > * If the probe point starts with '%', > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index bbfb8110947c..0c3d086cc22a 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -510,6 +510,9 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event > struct list_head *list; > int err; > > + parse_events_unused_value(&$3); > + parse_events_unused_value(&$5); > + > list = alloc_list(); > ABORT_ON(!list); > err = parse_events_add_breakpoint(_parse_state, list, > @@ -528,6 +531,8 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE opt_event_config > struct list_head *list; > int err; > > + parse_events_unused_value(&$3); > + > list = alloc_list(); > ABORT_ON(!list); > err = parse_events_add_breakpoint(_parse_state, list, > @@ -545,6 +550,8 @@ PE_PREFIX_MEM PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config > struct list_head *list; > int err; > > + parse_events_unused_value(&$3); > + > list = alloc_list(); > ABORT_ON(!list); > err = parse_events_add_breakpoint(_parse_state, list, > -- > 2.34.1 > > -- - Arnaldo