From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf stat: Add missing newline in pr_err messages
Date: Tue, 13 Jun 2023 16:45:09 -0300 [thread overview]
Message-ID: <ZIjHRfq0/IJPyhYT@kernel.org> (raw)
In-Reply-To: <cd1d5a4b-e69c-84c9-3e27-d197042df904@huawei.com>
Em Tue, Jun 13, 2023 at 09:32:05AM +0800, Yang Jihong escreveu:
> On 2023/6/13 2:55, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Jun 10, 2023 at 09:44:41AM +0000, Yang Jihong escreveu:
> > > The newline is missing for error messages in add_default_attributes()
> > >
> > > Before:
> > >
> > > # perf stat --topdown
> > > Topdown requested but the topdown metric groups aren't present.
> > > (See perf list the metric groups have names like TopdownL1)#
> > >
> > > After:
> > >
> > > # perf stat --topdown
> > > Topdown requested but the topdown metric groups aren't present.
> > > (See perf list the metric groups have names like TopdownL1)
> > > #
> > >
> > > In addition, perf_stat_init_aggr_mode() and perf_stat_init_aggr_mode_file()
> > > have the same problem, fixed by the way.
> >
> > Wait a bit till I push what I had to perf-tools-next, as it is not
> > applying right now:
> OK, I'm doing the patch based on the mainline, and if I need to do it based
> on the perf-tools-next branch, I'll reissue it.
For patches for the currente perf development cycle the perf-tools-next
branch of:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
Should be used.
Hopefully soon we will transition to:
git://git.kernel.org/pub/scm/linux/kernel/git/perf-tools/perf-tools-next.git
And also:
git://git.kernel.org/pub/scm/linux/kernel/git/perf-tools/perf-tools.git
For fixes geared to the current merge window, when we are accepting just
fixes.
- Arnaldo
next prev parent reply other threads:[~2023-06-13 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 9:44 [PATCH v2] perf stat: Add missing newline in pr_err messages Yang Jihong
2023-06-12 8:31 ` James Clark
2023-06-12 18:55 ` Arnaldo Carvalho de Melo
2023-06-13 1:32 ` Yang Jihong
2023-06-13 19:45 ` Arnaldo Carvalho de Melo [this message]
2023-06-14 2:12 ` Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIjHRfq0/IJPyhYT@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).