linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: namhyung@kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org
Subject: Perf stat regression from d15480a3d67
Date: Wed, 21 Jun 2023 18:39:41 -0700	[thread overview]
Message-ID: <ZJOmXU/41HMzanM9@tassilo> (raw)

Hi Namhyung,

I have a tool (toplev in pmu-tools) that parses the perf stat output
for generated command lines. It expects that the output contains the
events in the same order as specified with -e.

Unfortunately this broke for uncore events. 
I bisected it down to the following commit.

I believe just arbitrarily hiding events will break any tool that parses
the perf stat output and expect the input order.

Can the original problem be fixed without hiding events?

Thanks,

-Andi

commit dd15480a3d67b9cf04a1f6f5d60f1c0dc018e22f
Author: Namhyung Kim <namhyung@kernel.org>
Date:   Wed Jan 25 11:24:31 2023 -0800

    perf stat: Hide invalid uncore event output for aggr mode

    The current display code for perf stat iterates given cpus and build the
    aggr map to collect the event data for the aggregation mode.





             reply	other threads:[~2023-06-22  1:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  1:39 Andi Kleen [this message]
2023-06-22  6:10 ` Perf stat regression from d15480a3d67 Ian Rogers
2023-06-22  9:20   ` Andi Kleen
2023-06-22 13:41     ` Ian Rogers
2023-06-22 19:09     ` Namhyung Kim
2023-06-22 20:15       ` Andi Kleen
2023-06-23  0:08         ` Namhyung Kim
2023-06-23 17:04           ` Andi Kleen
2023-06-23 18:35           ` Andi Kleen
2023-06-23 18:53             ` Ian Rogers
2023-06-23 23:04               ` Namhyung Kim
2023-06-24 17:59                 ` Andi Kleen
2023-06-26  5:33                   ` Ian Rogers
2023-06-26 23:09                   ` Namhyung Kim
2023-06-26 23:52                     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJOmXU/41HMzanM9@tassilo \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).