From: Andi Kleen <ak@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org, acme@kernel.org
Subject: Re: Perf stat regression from d15480a3d67
Date: Mon, 26 Jun 2023 16:52:52 -0700 [thread overview]
Message-ID: <ZJok1Da3j2WzWsoN@tassilo> (raw)
In-Reply-To: <CAM9d7chyic6tf0nvJVE+Mt+X0fagecxESqVj9=pLNtxbCP5NeQ@mail.gmail.com>
> > >
> > > Right, not sure what's changed though.
> > >
> > > Andi, what's your expectation?
> >
> > The original test case passes with perf-next, but I still see failures,
> > but that might be related to PMU reordering. I'll investigate that.
> >
> > However if the original hiding is still in the code the problem could still
> > happen, right? I would still prefer to do what i suggested earlier,
> > to only do hiding on --per-thread with an option to turn off.
>
> I think the hiding should not happen in normal conditions
> besides the --per-thread. So I want to be clear what makes
> it disappears. Then we can decide what to do.
Okay I'll watch it and see if it happens again for next.
However if it's broken in some stable might also need to double
check that.
-Andi
prev parent reply other threads:[~2023-06-26 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 1:39 Perf stat regression from d15480a3d67 Andi Kleen
2023-06-22 6:10 ` Ian Rogers
2023-06-22 9:20 ` Andi Kleen
2023-06-22 13:41 ` Ian Rogers
2023-06-22 19:09 ` Namhyung Kim
2023-06-22 20:15 ` Andi Kleen
2023-06-23 0:08 ` Namhyung Kim
2023-06-23 17:04 ` Andi Kleen
2023-06-23 18:35 ` Andi Kleen
2023-06-23 18:53 ` Ian Rogers
2023-06-23 23:04 ` Namhyung Kim
2023-06-24 17:59 ` Andi Kleen
2023-06-26 5:33 ` Ian Rogers
2023-06-26 23:09 ` Namhyung Kim
2023-06-26 23:52 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJok1Da3j2WzWsoN@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).