From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A53EB64DC for ; Tue, 11 Jul 2023 14:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbjGKOmE (ORCPT ); Tue, 11 Jul 2023 10:42:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbjGKOmD (ORCPT ); Tue, 11 Jul 2023 10:42:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D24A0CF; Tue, 11 Jul 2023 07:42:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23C0661503; Tue, 11 Jul 2023 14:42:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54E15C433C8; Tue, 11 Jul 2023 14:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689086521; bh=MdxCExtG1yS5jseJzhYZubJ18kck0OwZ+QV+A9naVKY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c1PABcnU24Ywv+A1RIENK8p3TeyiKe/iVroyJMvpggIJp5J9YHPZFZb79dEBpNU2U kQ2P1OKeqvnPHJjT/HYtKNEGMGmCCJtycWVETjBGz37mf3hQtz0qUqZ3kQrHcX0yVk 8QiasGvR3D+gxYtaAtlVbHp7ggPNKTSOxYE35350xQCoLcKTDT4vJawKuvWv/WaHOJ KkG+T+SKPXFwskQXV2MA1kXZrBKvWZtIoMtN7fr4xdJPINq9c2VgdoNof1Jud4IPLf OvgUp1kyTdqH3VRR6Vnf1WCoPJ0cB+xibQ2uLhqExOO9OV0NBuxfUaNZIqz8Y5EV6W Uj8GQTQWOo/5w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D1FC640516; Tue, 11 Jul 2023 11:41:58 -0300 (-03) Date: Tue, 11 Jul 2023 11:41:58 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Georg =?iso-8859-1?Q?M=FCller?= , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , regressions@lists.linux.dev, Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf probe: read DWARF files from the correct CU Message-ID: References: <5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net> <20230615200147.664346-3-georgmueller@gmx.net> <20230711222000.d316cf7fd643cb4203ea1204@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230711222000.d316cf7fd643cb4203ea1204@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Jul 11, 2023 at 10:20:00PM +0900, Masami Hiramatsu escreveu: > On Tue, 11 Jul 2023 09:57:45 -0300 Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 15, 2023 at 10:01:37PM +0200, Georg Müller escreveu: > > > The problem is that die_get_decl_file() uses the wrong CU to search for > > > the file. elfutils commit e1db5cdc9f has some good explanation for this: > > > > > > dwarf_decl_file uses dwarf_attr_integrate to get the DW_AT_decl_file > > > attribute. This means the attribute might come from a different DIE > > > in a different CU. If so, we need to use the CU associated with the > > > attribute, not the original DIE, to resolve the file name. > > > > > > This patch uses the same source of information as elfutils: use attribute > > > DW_AT_decl_file and use this CU to search for the file. > > > > Thanks, applied to the perf-tools branch, that will be submitted for > > Linux v6.5. > Thanks Arnaldo and Georg, > It sounds perfect reason why that happened. I didn't expect the case that > the attribute comes from another CU... > Acked-by: Masami Hiramatsu (Google) Thanks, added it to the cset. - Arnaldo