From: Andi Kleen <ak@linux.intel.com>
To: irogers@google.com
Cc: linux-perf-users@vger.kernel.org
Subject: perf command line error handling regression
Date: Thu, 13 Jul 2023 09:42:45 -0700 [thread overview]
Message-ID: <ZLAphRzys2lcNICF@tassilo> (raw)
Ian,
Since the commit below, I see the following:
$ perf foo
Segmentation fault (core dumped)
$
Before:
$ perf foo
perf: 'foo' is not a perf-command. See 'perf --help'.
$
(gdb) bt
#0 0x00007ffff6f89fe2 in __strcmp_evex () from /lib64/libc.so.6
#1 0x00007ffff6e6387d in msort_with_tmp.part () from /lib64/libc.so.6
#2 0x00007ffff6e63bd6 in qsort_r () from /lib64/libc.so.6
#3 0x00000000005895af in help_unknown_cmd (cmd=cmd@entry=0x7fffffffdaf2 "foo") at util/help-unknown-cmd.c:71
#4 0x000000000040cb52 in main (argc=1, argv=0x7fffffffd750) at perf.c:543
commit 657a3efee43a29d13c4f30e4c8f6a178fd2bf14a
Author: Ian Rogers <irogers@google.com>
Date: Sun Jun 11 16:36:06 2023 -0700
lib subcmd: Avoid memory leak in exclude_cmds
exclude_cmds will shorten the cmds names array, before doing so free the
removed entry.
next reply other threads:[~2023-07-13 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 16:42 Andi Kleen [this message]
2023-07-13 21:29 ` perf command line error handling regression Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAphRzys2lcNICF@tassilo \
--to=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).