From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
namhyung@kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: Event reordering regression for software events
Date: Wed, 26 Jul 2023 08:05:46 -0700 [thread overview]
Message-ID: <ZME2SpcW945IqhcN@tassilo> (raw)
In-Reply-To: <ZLVEHz0uzq79eto5@kernel.org>
<sorry for the late reply I was on vacation>
On Mon, Jul 17, 2023 at 10:37:35AM -0300, Arnaldo Carvalho de Melo wrote:
> Don't we have a JSON output? My expectation is that after the work that
> Ian has been doing we will settle down, but even then downstreamers
> should try to use JSON as input as that would avoid the problems we are
> having?
In classic perf CSV was our machine readable output, and that is what got broken
here. I hope nobody is advocating for abolishing CSV output as a machine
readable format.
For JSON it got broken too because of:
> > I haven't tried to use it, but if you have something like
> > perf stat --json -e '{cycles,branches},{cycles,cache-misses}' how would you
> > distinguish it without order?
>
> You mentioned that it was difficult to add entries to 'perf test' but
I can add some tests for basic reordering not occurring. That should
be possible.
> that we could try running toplev's regression test, right? I can add it
> to my set of tests but perhaps the best thing would be to wire it up to
> one of the CIs out there?
Yes that would be a good idea. Note that there are sometimes problems
which are on the toplev side, not perf side, but I guess can sort that
out when that happens.
-And
next prev parent reply other threads:[~2023-07-26 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 20:37 Event reordering regression for software events Andi Kleen
2023-07-13 20:48 ` Arnaldo Carvalho de Melo
2023-07-13 21:24 ` Ian Rogers
2023-07-13 23:51 ` Andi Kleen
2023-07-14 1:14 ` Ian Rogers
2023-07-14 3:07 ` Andi Kleen
2023-07-14 3:56 ` Ian Rogers
2023-07-17 2:00 ` Andi Kleen
2023-07-17 13:37 ` Arnaldo Carvalho de Melo
2023-07-26 15:05 ` Andi Kleen [this message]
2023-07-18 18:25 ` Ian Rogers
2023-07-19 0:53 ` Ian Rogers
2023-07-13 23:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZME2SpcW945IqhcN@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).