From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C73DC00528 for ; Thu, 27 Jul 2023 20:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjG0UGI (ORCPT ); Thu, 27 Jul 2023 16:06:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbjG0UGF (ORCPT ); Thu, 27 Jul 2023 16:06:05 -0400 Received: from mgamail.intel.com (unknown [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6E3C2D7D; Thu, 27 Jul 2023 13:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690488357; x=1722024357; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Msn3P7XhihBuXIiP755PoG7r2oz2s+xBr5H2iJd5InA=; b=Tk6poIR7i+qalq+p0aRuMFmPpBlTQH98Osu9Wfuui4aI9zsK/isczqhg bpjyOQ9uoHfT61Tvw4UJ/RIWnZIUWTCHyyUw8OM4bpVPK0lr4wnGC3/Rg iPYNEupQgGLVF5OU4hlduyB9OGDXjYwHrT3W7O325ApyUxSa0R9PjAas9 S1XpLuLIx2W4bikGzIAZktRBRnQFBEoTio+d6B0mR3QXMMoxlfSWbb2cA SNrsZ7onWpHNTLLZHpZw6/Ch5dGZVJuz6IG40t6O3mI2XQb9PTPWWiZmS 5I09L+8fD2s0yZXPpdfVW8m5kTGBkJaq3upBA4F+i0L5RHjW9XBEGxekQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="365879766" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="365879766" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 13:05:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="727147160" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="727147160" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 13:05:57 -0700 Date: Thu, 27 Jul 2023 13:05:56 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Zhengjun Xing , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/3] Parse event sort/regroup fixes Message-ID: References: <20230719001836.198363-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Wed, Jul 19, 2023 at 11:49:47AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 18, 2023 at 05:18:33PM -0700, Ian Rogers escreveu: > > Patch 1, fix: > > perf stat -e cycles,slots,topdown-fe-bound > > so that cycles isn't made a group leader (failure caused by PMUs > > matching). Previously this event list would fail so not necessarily a > > regression over previous perf release. > > > > Patch 2, when regrouping events the leader needs to be updated due to > > sorting. This fix causes larger event groups that then regress at > > least the tigerlake metric test as the kernel PMU driver fails to > > break the weak groups. This is a fix for a bug but the consequence of > > fixing the bug is to make a passing test fail due to the kernel PMU > > driver. > > > > Patch 3, don't alter the list position of events without a group if > > they don't need forcing into a group. Analysis showed this was the > > cause of the issue reported by Andi Kleen: > > https://lore.kernel.org/linux-perf-users/ZLBgbHkbrfGygM%2Fu@tassilo/ > > Andi, > > Can you please check these patches and provide a Tested-by? Tested-by: Andi Kleen -Andi