From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0E0C001DE for ; Fri, 28 Jul 2023 18:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233901AbjG1Snu (ORCPT ); Fri, 28 Jul 2023 14:43:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233836AbjG1Sna (ORCPT ); Fri, 28 Jul 2023 14:43:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F00554488; Fri, 28 Jul 2023 11:43:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66A5F621DD; Fri, 28 Jul 2023 18:43:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95535C433C7; Fri, 28 Jul 2023 18:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690569796; bh=EtSfBpi27VvgA4ooHcYUqNF5uegw1JHfetF61N9a7HQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FPG1l3xH1ifeG6nhuOiFu05xMcBxSGuWRwPUrh+Bm9KyctZ30P3wuw5Id1XXMksEE Zl/qm8Qnc8BNtkx/1HPlt1ZbQtYXI16Ay8ILYVzEBlC6lsGDcDHZSppyl2kN+vfk32 rUbUfZHt+FAe3adEZHdQqB3vnV+gseOSPZyc7aF/fMAIXQ6/9WASxu9QRh1SP6bFGY +toq7o+GxDROIm/8cSot0XyXUzy5CJMY9/DDWs2eE+7Oijp47bHC7gzZiNO8fxhEuC WayJTloYrIp3+kdAhpenXfRufIA5L/wurp7eUwXk+GrfRY9d5DRSGy7AVknzMgE0zt p5qzC56zCUpOw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 6EF2E40096; Fri, 28 Jul 2023 15:43:14 -0300 (-03) Date: Fri, 28 Jul 2023 15:43:14 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v1 4/6] perf build: Disable fewer flex warnings Message-ID: References: <20230728064917.767761-1-irogers@google.com> <20230728064917.767761-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Jul 28, 2023 at 03:10:05PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jul 28, 2023 at 08:26:54AM -0700, Ian Rogers escreveu: > > On Fri, Jul 28, 2023 at 7:02 AM Arnaldo Carvalho de Melo > > > I added this to the patch to get it moving: > > > > > > make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf' > > > ⬢[acme@toolbox perf-tools-next]$ git diff > > > diff --git a/tools/perf/util/Build b/tools/perf/util/Build > > > index 32239c4b0393c319..afa93eff495811cf 100644 > > > --- a/tools/perf/util/Build > > > +++ b/tools/perf/util/Build > > > @@ -281,7 +281,7 @@ $(OUTPUT)util/bpf-filter-bison.c $(OUTPUT)util/bpf-filter-bison.h: util/bpf-filt > > > > > > FLEX_GE_264 := $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\= 264) > > > ifeq ($(FLEX_GE_264),1) > > > - flex_flags := -Wno-redundant-decls -Wno-switch-default -Wno-unused-function > > > + flex_flags := -Wno-redundant-decls -Wno-switch-default -Wno-unused-function -Wno-misleading-indentation > > > else > > > flex_flags := -w > > > endif > > > ⬢[acme@toolbox perf-tools-next]$ > > > > > > > > > > 1 error generated. > > > > make[4]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:97: util/parse-events-flex.o] Error 1 > > > > make[4]: *** Waiting for unfinished jobs.... > > > > LD util/scripting-engines/perf-in.o > > > > make[3]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:140: util] Error 2 > > > > make[2]: *** [Makefile.perf:682: perf-in.o] Error 2 > > > > make[2]: *** Waiting for unfinished jobs.... > > > > CC pmu-events/pmu-events.o > > > > LD pmu-events/pmu-events-in.o > > > > make[1]: *** [Makefile.perf:242: sub-make] Error 2 > > > > make: *** [Makefile:70: all] Error 2 > > > > > > > > ⬢[acme@toolbox perf-tools-next]$ clang --version > > > > clang version 14.0.5 (Fedora 14.0.5-2.fc36) > > > > Target: x86_64-redhat-linux-gnu > > > > Thread model: posix > > > > InstalledDir: /usr/bin > > > > ⬢[acme@toolbox perf-tools-next]$ > > > > Thanks James/Arnaldo, I was trying to be aggressive in having more > > flags, but it seems too aggressive. We should probably bring back the > > logic to make this flag only added if it is supported: > > CC_HASNT_MISLEADING_INDENTATION := $(shell echo "int main(void) { > > return 0 }" | $(CC) -Werror -Wno-misleading-indentation -o /dev/null > > -xc - 2>&1 | grep -q -- -Wno-misleading-indentation ; echo $$?) > > ifeq ($(CC_HASNT_MISLEADING_INDENTATION), 1) > > flex_flags += -Wno-misleading-indentation > > endif > > Arnaldo, is the misleading indentation in the bison generated code or > > something copy-pasted from the parse-events.l ? If the latter we may > > be able to fix the .l file to keep the warning. > > I haven't checked, lemme do it now. It comes directly from flex's m4 files: https://github.com/westes/flex/blob/master/src/c99-flex.skl#L2044 So I'll keep the -Wno-misleading-indentation, ok? - Arnaldo