linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] tools: perf: pmu-events: Fix typo poiint->point
       [not found] <20230803-fix-typo-v1-1-b794378d594e@manank.me>
@ 2023-08-03 20:45 ` Arnaldo Carvalho de Melo
  2023-08-10 22:02   ` Ian Rogers
  0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-08-03 20:45 UTC (permalink / raw)
  To: Manank Patel
  Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, Ian Rogers, Adrian Hunter,
	Maxime Coquelin, Alexandre Torgue, linux-perf-users, linux-kernel,
	linux-stm32, linux-arm-kernel, Jens Schleusener

Em Thu, Aug 03, 2023 at 11:27:30AM +0530, Manank Patel escreveu:
> Fix typo in file floating-point.json in /arch/x86/westmereep-dp

AFAIK these are generated using a tool, so the fix needs to go to the
file from where the JSON files are generated, Ian?

- Arnaldo
 
> Reported-by: Jens Schleusener <Jens.Schleusener@fossies.org>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205891
> Signed-off-by: Manank Patel <manank@manank.me>
> ---
>  tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json b/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> index c03f8990fa82..196ae1d9b157 100644
> --- a/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> +++ b/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> @@ -8,7 +8,7 @@
>          "UMask": "0x1"
>      },
>      {
> -        "BriefDescription": "X87 Floating poiint assists for invalid input value (Precise Event)",
> +        "BriefDescription": "X87 Floating point assists for invalid input value (Precise Event)",
>          "EventCode": "0xF7",
>          "EventName": "FP_ASSIST.INPUT",
>          "PEBS": "1",
> 
> ---
> base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
> change-id: 20230803-fix-typo-3cb207284310
> 
> Best regards,
> -- 
> Manank Patel <manank@manank.me>
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] tools: perf: pmu-events: Fix typo poiint->point
  2023-08-03 20:45 ` [PATCH] tools: perf: pmu-events: Fix typo poiint->point Arnaldo Carvalho de Melo
@ 2023-08-10 22:02   ` Ian Rogers
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Rogers @ 2023-08-10 22:02 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, Edward
  Cc: Manank Patel, Peter Zijlstra, Ingo Molnar, Mark Rutland,
	Alexander Shishkin, Jiri Olsa, Namhyung Kim, Adrian Hunter,
	Maxime Coquelin, Alexandre Torgue, linux-perf-users, linux-kernel,
	linux-stm32, linux-arm-kernel, Jens Schleusener

On Thu, Aug 3, 2023 at 1:45 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Em Thu, Aug 03, 2023 at 11:27:30AM +0530, Manank Patel escreveu:
> > Fix typo in file floating-point.json in /arch/x86/westmereep-dp
>
> AFAIK these are generated using a tool, so the fix needs to go to the
> file from where the JSON files are generated, Ian?

Yes, these are generated by the script:
https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
Added Edward Baker at Intel who can correct these issues at source.

Thanks,
Ian

> - Arnaldo
>
> > Reported-by: Jens Schleusener <Jens.Schleusener@fossies.org>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=205891
> > Signed-off-by: Manank Patel <manank@manank.me>
> > ---
> >  tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json b/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> > index c03f8990fa82..196ae1d9b157 100644
> > --- a/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> > +++ b/tools/perf/pmu-events/arch/x86/westmereep-dp/floating-point.json
> > @@ -8,7 +8,7 @@
> >          "UMask": "0x1"
> >      },
> >      {
> > -        "BriefDescription": "X87 Floating poiint assists for invalid input value (Precise Event)",
> > +        "BriefDescription": "X87 Floating point assists for invalid input value (Precise Event)",
> >          "EventCode": "0xF7",
> >          "EventName": "FP_ASSIST.INPUT",
> >          "PEBS": "1",
> >
> > ---
> > base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
> > change-id: 20230803-fix-typo-3cb207284310
> >
> > Best regards,
> > --
> > Manank Patel <manank@manank.me>
> >
>
> --
>
> - Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-10 22:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230803-fix-typo-v1-1-b794378d594e@manank.me>
2023-08-03 20:45 ` [PATCH] tools: perf: pmu-events: Fix typo poiint->point Arnaldo Carvalho de Melo
2023-08-10 22:02   ` Ian Rogers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).