From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62E1C00528 for ; Thu, 3 Aug 2023 20:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbjHCUzE (ORCPT ); Thu, 3 Aug 2023 16:55:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbjHCUzD (ORCPT ); Thu, 3 Aug 2023 16:55:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E0E1990; Thu, 3 Aug 2023 13:55:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B78A61EA9; Thu, 3 Aug 2023 20:55:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFEA6C433C8; Thu, 3 Aug 2023 20:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691096102; bh=J0pw286lqUZz/i8c9f1pp7D3EBEVQFjY/BPNNe+g5/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tPF1San+pjrHnaPYnj5ratiNxm/hmI1PME1zK2aRIhPZ5LubCUwj2+djZ7SjtRYkf GKegSKLpMerR8dAaSlWu3vvG88TwLLhjlYPsBnHybWBPmNwn/NPwCHhoV35LBvDVj1 asUfNMVGnbxUq3rftrWpX3XP0h8tYu1yNieQQ5fFsSkn1xymk18tYAhvHvKqjt0Ziz gNkEYrsm9ZFAaVavmEjCXhLt6lKl6rkD4daWGB4EkKa3O4sAe97c4MjDjfPV6R+bAT ps3fsBYVBIcji2J9PQqADNaCNSAESE96Uvy6MCzZKGd5iLqnRDbgJifGsm7zZDaG8d 6m95HVIYrtQPA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5A518404DF; Thu, 3 Aug 2023 17:54:59 -0300 (-03) Date: Thu, 3 Aug 2023 17:54:59 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Athira Rajeev , Claire Jensen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] perf stat: Don't display zero tool counts Message-ID: References: <20230801205452.3380578-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801205452.3380578-1-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Aug 01, 2023 at 01:54:52PM -0700, Ian Rogers escreveu: > Skip zero counts for tool events. > > Reported-by: Andi Kleen Andi, Have you tested this? Can we please have your Tested-by? - Arnaldo:1 > Signed-off-by: Ian Rogers > --- > tools/perf/util/stat-display.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 7329b3340f88..d45d5dcb0e2b 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -931,6 +931,11 @@ static bool should_skip_zero_counter(struct perf_stat_config *config, > */ > if (config->aggr_mode == AGGR_THREAD && config->system_wide) > return true; > + > + /* Tool events have the software PMU but are only gathered on 1. */ > + if (evsel__is_tool(counter)) > + return true; > + > /* > * Skip value 0 when it's an uncore event and the given aggr id > * does not belong to the PMU cpumask. > -- > 2.41.0.585.gd2178a4bd4-goog > -- - Arnaldo