From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFF9C001E0 for ; Tue, 15 Aug 2023 18:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239403AbjHOStR (ORCPT ); Tue, 15 Aug 2023 14:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239484AbjHOStN (ORCPT ); Tue, 15 Aug 2023 14:49:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519CB2122; Tue, 15 Aug 2023 11:48:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 80B4465EEF; Tue, 15 Aug 2023 18:45:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83888C433C7; Tue, 15 Aug 2023 18:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692125130; bh=iRqVcT0rx/WBeVqvZr8C3SmuYLCDnBwbzwYnneJXSK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oF9Q/hImdY6G1jhqdYXJP0Ku/URDmEnEu1wdvPRGFwSCIfV6MAKG2DYu0XvgHfoXl mfFFxW+dy5g9tNSfv4YGNswzIuXYAfED8BGYGrZA1Lu80j3a70CBYLsOHqZMb9HNL4 X73Td1Wf6ZkNsXO1jfFgv2HgoUfVskhG27U0oOvFFFT5YYDZPg7o6jPi67Q7HV75nO c/21A9DPoRe4gk8AEm2+mL/VPbfo1xHy3uBvM/FBBDSbiMXooBL79JvJ58i9z/qWfk nxTGcpJ1M4hHoIFmmQ+3XYKDpCzAgxXB9vuIV/vJkyq/C4GUMI6WWqTkiq/FVhNzJY dxXK1JFr66ozA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EE356404DF; Tue, 15 Aug 2023 15:45:27 -0300 (-03) Date: Tue, 15 Aug 2023 15:45:27 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Leo Yan , John Garry , Will Deacon , James Clark , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , Ming Wang , Eric Lin , Kan Liang , Sandipan Das , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Message-ID: References: <20230606014559.21783-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Aug 15, 2023 at 03:24:04PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jul 12, 2023 at 03:37:36PM -0700, Ian Rogers escreveu: > > On Mon, Jun 5, 2023 at 6:46 PM Leo Yan wrote: > > > > > > This patch series is to refactor arch related functions for register > > > parsing, which follows up the discussion for v1: > > > https://lore.kernel.org/lkml/20230520025537.1811986-1-leo.yan@linaro.org/ > > > > > > Compared to patch series v1, this patch series introduces new functions > > > perf_arch_reg_{ip|sp}(), so this can allow the tool to support cross > > > analysis. > > > > > > To verify the cross analysis, I used below steps: > > > > > > - Firstly, I captured perf data on Arm64 machine: > > > > > > $ perf record --call-graph fp -- ./test_program > > > > > > Or ... > > > > > > $ perf record --call-graph dwarf -- ./test_program > > > > > > Then, I also archived associated debug data: > > > > > > $ perf archive > > > > > > - Secondly, I copied the perf data file and debug tar file on my x86 > > > machine: > > > > > > $ scp perf.data perf.data.tar.bz2 leoy@IP_ADDRESS:/target/path/ > > > > > > - On x86 machine, I need to build perf for support multi-arch unwinding: > > > > > > $ git clone http://git.savannah.gnu.org/r/libunwind.git > > > $ cd libunwind > > > $ autoreconf -i > > > > > > # Build and install libunwind aarch64: > > > $ ./configure prefix=/home/leoy/Work/tools/libunwind/install/ \ > > > --target=aarch64-linux-gnu CC=x86_64-linux-gnu-gcc > > > $ make && make install > > > > > > # Build and install libunwind x86: > > > $ ./configure prefix=/home/leoy/Work/tools/libunwind/install/ \ > > > --target=x86_64-linux-gnu CC=x86_64-linux-gnu-gcc > > > $ make && make install > > > > > > - Build perf tool for support multi-archs: > > > > > > $ cd $LINUX/tools/perf > > > $ make VF=1 DEBUG=1 LIBUNWIND_DIR=/home/leoy/Work/tools/libunwind/install > > > > > > At the end, I verified the x86 perf tool can do cross analysis for aarch64's > > > perf data file. > > > > > > Note, I still see x86 perf tool cannot display the complete callgraph > > > for aarch64, but it should not the issue caused by this series, which > > > will be addressed by separate patches. > > > > > > I also built this patch series on my Arm64 and x86 machines, both can > > > compile perf tool successfully; but I have no chance to build other > > > archs natively. > > > > > > Changes from v1: > > > - For support cross analysis for IP/SP registers, introduced patch 0002 > > > (James Clark, Ian Rogers). > > > > > > > > > Leo Yan (6): > > > perf parse-regs: Refactor arch register parsing functions > > > perf parse-regs: Introduce functions perf_arch_reg_{ip|sp}() > > > perf unwind: Use perf_arch_reg_{ip|sp}() to substitute macros > > > perf parse-regs: Remove unused macros PERF_REG_{IP|SP} > > > perf parse-regs: Remove PERF_REGS_{MAX|MASK} from common code > > > perf parse-regs: Move out arch specific header from util/perf_regs.h > > > > Sorry for the slow review. For the series: > > Acked-by: Ian Rogers > > > > Some thoughts: > > uint64_t __perf_reg_ip_arm(void) > > uint64_t seems like we're giving a lot of space for future register > > encodings. I think some of the other functions use this size of value > > due to returning a bitmap/mask, but here it isn't clear and just feels > > excessive. > > > > Do we need the "__" prefix on all the functions? > > > > In Makefile.config there are NO_PERF_REGS and CONFIG_PERF_REGS then > > the define HAVE_PERF_REGS_SUPPORT. Is this still relevant? If we had > > an architecture with no support, couldn't it still read a perf.data > > file from a supported architecture? It would be nice to remove at > > least NO_PERF_REGS and HAVE_PERF_REGS_SUPPORT. > > > > This change is very worthwhile fix and cleanup, it didn't introduce > > what is pondered above, hence the acked-by. > > Agreed, applied to perf-tools-next, sorry for the delay. Had to add this to make 'perf test python' to work. Please run 'perf test' before sending patches. - Arnaldo diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources index d4c9b4cd35efa556..26e1c8d973ea0b95 100644 --- a/tools/perf/util/python-ext-sources +++ b/tools/perf/util/python-ext-sources @@ -40,3 +40,12 @@ util/rwsem.c util/hashmap.c util/perf_regs.c util/fncache.c +util/perf-regs-arch/perf_regs_aarch64.c +util/perf-regs-arch/perf_regs_arm.c +util/perf-regs-arch/perf_regs_csky.c +util/perf-regs-arch/perf_regs_loongarch.c +util/perf-regs-arch/perf_regs_mips.c +util/perf-regs-arch/perf_regs_powerpc.c +util/perf-regs-arch/perf_regs_riscv.c +util/perf-regs-arch/perf_regs_s390.c +util/perf-regs-arch/perf_regs_x86.c