From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E73FC04FE0 for ; Wed, 16 Aug 2023 16:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344602AbjHPQPn (ORCPT ); Wed, 16 Aug 2023 12:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344709AbjHPQPd (ORCPT ); Wed, 16 Aug 2023 12:15:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76232735; Wed, 16 Aug 2023 09:15:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1361261E6B; Wed, 16 Aug 2023 16:15:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33AFDC433C8; Wed, 16 Aug 2023 16:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692202528; bh=OMgLR3TAr3QUpgpqAJtIIBRt8Ct7rrg/kr/lcSjos2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b5QxCJ4xFGNgNBzb1URIai5wj/jPmfXILqlqMg96XnhR+6JhOdcdZWjwVZf7fNnGn ZcSY37sRWskbbb5NtiJVNFZQjSPlYDUdMxV55kh0kCa50tU3skqHbHbAYm0nj4lYfG MnQcihtAidaY58rJ+sdV9oF0oturZ8BOctRNsGJAbgE72Pu5/MJRYeqhU5ZRr29FTN NQkQBEiH8sQEqj7HpbBwdT4Tos/PCr6adj0RVR/JK/zy8PwukC4gtR+uZE5asUZ2e2 IVus2ObAFRrlsOjgrXaKqOq06bxqPQyq2mSBUR6msqI4NoviScZMfaNJrFcZDkqpK7 IYjw33VtVQPtQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EAB1E404DF; Wed, 16 Aug 2023 13:15:24 -0300 (-03) Date: Wed, 16 Aug 2023 13:15:24 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, john.g.garry@oracle.com, renyu.zj@linux.alibaba.com, Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kajol Jain , Kan Liang , Haixin Yu , Nick Forrington , Eduard Zingerman , Sohom Datta , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/6] perf vendor events arm64: Update scale units and descriptions of common topdown metrics Message-ID: References: <20230816114841.1679234-1-james.clark@arm.com> <20230816114841.1679234-4-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230816114841.1679234-4-james.clark@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Aug 16, 2023 at 12:47:45PM +0100, James Clark escreveu: > Metrics will be published here [1] going forwards, but they have > slightly different scale units. To allow autogenerated metrics to be > added more easily, update the scale units to match. > > The more detailed descriptions have also been taken and added to the > common file. > > [1]: https://gitlab.arm.com/telemetry-solution/telemetry-solution/-/tree/main/data/pmu/cpu/ This one I had cherry-picked and is already in perf-tools-next, I applied the others locally, will wait till later to see if people ack/object. - Arnaldo > Acked-by: Ian Rogers > Reviewed-by: John Garry > Signed-off-by: James Clark > --- > tools/perf/pmu-events/arch/arm64/sbsa.json | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json > index f90b338261ac..4eed79a28f6e 100644 > --- a/tools/perf/pmu-events/arch/arm64/sbsa.json > +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json > @@ -1,34 +1,34 @@ > [ > { > - "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)", > - "BriefDescription": "Frontend bound L1 topdown metric", > + "MetricExpr": "100 * (stall_slot_frontend / (#slots * cpu_cycles))", > + "BriefDescription": "This metric is the percentage of total slots that were stalled due to resource constraints in the frontend of the processor.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "frontend_bound", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))", > - "BriefDescription": "Bad speculation L1 topdown metric", > + "MetricExpr": "100 * ((1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles)))", > + "BriefDescription": "This metric is the percentage of total slots that executed operations and didn't retire due to a pipeline flush.\nThis indicates cycles that were utilized but inefficiently.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "bad_speculation", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))", > - "BriefDescription": "Retiring L1 topdown metric", > + "MetricExpr": "100 * ((op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles)))", > + "BriefDescription": "This metric is the percentage of total slots that retired operations, which indicates cycles that were utilized efficiently.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "retiring", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)", > - "BriefDescription": "Backend Bound L1 topdown metric", > + "MetricExpr": "100 * (stall_slot_backend / (#slots * cpu_cycles))", > + "BriefDescription": "This metric is the percentage of total slots that were stalled due to resource constraints in the backend of the processor.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "backend_bound", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > } > ] > -- > 2.34.1 > -- - Arnaldo