From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B447CA0FF3 for ; Tue, 5 Sep 2023 16:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235425AbjIEQCN (ORCPT ); Tue, 5 Sep 2023 12:02:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354560AbjIEMkP (ORCPT ); Tue, 5 Sep 2023 08:40:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9C6F18D; Tue, 5 Sep 2023 05:40:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59731B811EA; Tue, 5 Sep 2023 12:40:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCC99C433C7; Tue, 5 Sep 2023 12:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693917606; bh=ZUN15+7Vyk5IoUudEUqouA7xZLURmNHDNxbTpmZ1Jj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FK80e1jI90yRK9VG2Wng+aZqrLbvt80jBUqkksvYVN/xcWCXrZTuf1mbaeXQdfH4P 5bE/D3E9J0ow5PYvTy+ABeCaeMlMsYwVtPcP5gC3rgfBDzkpCs213oiK6e8yYDdHfC YOuhhNSd9yvEvsfjRvhxYqIs7khKR1OQhsAvXv6Mis9nVvO46R2KToA6IVqvCRGrpG j9qSGwo0lcgw5NheBEFVNJuuMPkzskFP7VM3lWmlgVB36TqYtCrpbzN2XaoucNBoLd MrWyQpu5XxePXEQMqVMbnf0BhRwru/VylosH8aGNUw67118fYpK03RKmh80SiXezDy HnEW1YLfrJvuw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DBA3840722; Tue, 5 Sep 2023 09:40:02 -0300 (-03) Date: Tue, 5 Sep 2023 09:40:02 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark Subject: Re: [PATCH v1] perf parse-events: Fix driver config term Message-ID: References: <20230905033805.3094293-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Sep 04, 2023 at 08:51:37PM -0700, Ian Rogers escreveu: > On Mon, Sep 4, 2023 at 8:38 PM Ian Rogers wrote: > > > > Inadvertently deleted in commit 30f4ade33d64 ("perf tools: Revert > > enable indices setting syntax for BPF map"). > > > > Sorry, should also have: > Fixes: 30f4ade33d64 ("perf tools: Revert enable indices setting syntax > for BPF map") I added it, thanks. > Thanks, > Ian > > > Reported-by: James Clark > > Signed-off-by: Ian Rogers > > --- > > tools/perf/util/parse-events.y | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > > index 4a305df61f74..21bfe7e0d944 100644 > > --- a/tools/perf/util/parse-events.y > > +++ b/tools/perf/util/parse-events.y > > @@ -839,6 +839,23 @@ PE_TERM > > > > $$ = term; > > } > > +| > > +PE_DRV_CFG_TERM > > +{ > > + struct parse_events_term *term; > > + char *config = strdup($1); > > + int err; > > + > > + if (!config) > > + YYNOMEM; > > + err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_DRV_CFG, config, $1, &@1, NULL); > > + if (err) { > > + free($1); > > + free(config); > > + PE_ABORT(err); > > + } > > + $$ = term; > > +} > > > > sep_dc: ':' | > > > > -- > > 2.42.0.283.g2d96d420d3-goog > > -- - Arnaldo