From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E2ACD37B4 for ; Sun, 17 Sep 2023 09:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233103AbjIQJWh (ORCPT ); Sun, 17 Sep 2023 05:22:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235181AbjIQJWJ (ORCPT ); Sun, 17 Sep 2023 05:22:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC76C188 for ; Sun, 17 Sep 2023 02:22:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235F3C433C7; Sun, 17 Sep 2023 09:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694942523; bh=/j4DWIsQgtSFEy5JH+6kgx9JVQPPEwKacezaH14fxjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J+DAL0AY2EA5aqVORmPxjz7DYGAZACn/9pSe/lHG2uQBukVs5eVTUxe/3ZLHfJKFX 15ioFzCDgghCVUx3CS3VowHiRqEs2NODXiN+8o22mzEYT41/19zAXNuhoiNGQwNV1T FtVfai2PDf+tnT+Rer9TFX7TMRaI4UnVl/XrhDMZUeniABbWzFJr39CGFAGy/GtYLs nNSi0tl63I56huAawdabSzM4KL7bw8wXl9pJSXIvhXtcN6pWPjRYwn/ZF7/Ugr6BBt zOW8Qj1iM+pow6K8OmXBkAd8LHCeZLGpUwWQZN4/jftj5zGpmbj3TDXnVKvy4mG3n5 TKZzruGch+Hbw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id AA31C403F4; Sun, 17 Sep 2023 11:22:00 +0200 (CEST) Date: Sun, 17 Sep 2023 11:22:00 +0200 From: Arnaldo Carvalho de Melo To: Manu Bretelle Cc: Mykola Lysenko , Alexei Starovoitov , Ravi Bangoria , Andrii Nakryiko , Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Ian Rogers , linux-perf-users , bpf , Daniel =?iso-8859-1?Q?M=FCller?= Subject: Re: [BUG] perf test: Regression because of d6e6286a12e7 Message-ID: References: <78044efc-98d7-cd49-d2b5-4c2abb16d6c9@amd.com> <146e00be-98c8-873d-081f-252647b71b12@amd.com> <87FAA9FD-C64E-4199-9F77-8671FF19EEE1@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Sep 14, 2023 at 09:43:41PM +0000, Manu Bretelle escreveu: > Hi Arnaldo, > Checking back here to see if there is anything you need help in order > to add perf support to BPF CI. Were you able to make progress and are > hitting some issues along the way? I'm travelling now, but I saw that Ian replied. No progress on my part, but I would start with a simple: Build perf from the same kernel source tree used in the current CI tests, then run 'perf test'. It would test more than just the BPF part, but would be a good start. A second step would be just disabling the tests that are failing and that are not BPF specific, using the --skip arg to 'perf test': [root@quaco test]# perf test -h skip Usage: perf test [] [{list |[|]}] -s, --skip tests to skip [root@quaco test]# So something like: ----------------- make -C tools/perf perf test --skip list,of,tests,failing,that,are,not,BPF,specific ----------------- The perf build dependencies should be similar to the ones needed to build libbpf or close to it, so the above would be a great first stab at it. - Arnaldo > > Thanks, > > Manu > > From: Mykola Lysenko > Date: Friday, July 14, 2023 at 11:15 AM > To: Arnaldo Carvalho de Melo > Cc: Mykola Lysenko , Alexei Starovoitov , Ravi Bangoria , Andrii Nakryiko , Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Ian Rogers , linux-perf-users , bpf , Manu Bretelle , Daniel Müller , Mykola Lysenko > Subject: Re: [BUG] perf test: Regression because of d6e6286a12e7 > Hey Arnaldo, > > > On Jul 13, 2023, at 1:57 PM, Arnaldo Carvalho de Melo wrote: > > > > !-------------------------------------------------------------------| > > This Message Is From an External Sender > > > > |-------------------------------------------------------------------! > > > > Em Wed, Jul 12, 2023 at 11:20:27AM -0700, Alexei Starovoitov escreveu: > >> On Wed, Jul 12, 2023 at 8:39 AM Arnaldo Carvalho de Melo > >> wrote: > >>> > >>> Right, perhaps the libbpf CI could try building perf, preferably with > >>> BUILD_BPF_SKEL=1, to enable these tools: > >> > >> > >> That would be great. > >> perf experts probably should do pull-req to bpf CI to enable that. > >> See slides: > >> http://vger.kernel.org/bpfconf2022_material/lsfmmbpf2022-bpf-ci.pdf > >> > >> "How to contribute? > >> Depending on what part of CI you are changing, you can create a pull request to > >> https://github.com/kernel-patches/vmtest/ > >> https://github.com/libbpf/ci > >> " > > > > Sure, I still recall Quentin's talk about CI, etc in Dublin, will come > > up with something and submit. > > Thanks for looking at this! > > If you will have any questions on how CI works, do not hesitate to join BPF office hours and we will do our best to answer. > > Mykola > > > > > - Arnaldo > -- - Arnaldo