From: Nicolas Schier <nicolas@fjasle.eu>
To: Ian Rogers <irogers@google.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Yang Jihong <yangjihong1@huawei.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ming Wang <wangming01@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Sean Christopherson <seanjc@google.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Yanteng Si <siyanteng@loongson.cn>, Yuan Can <yuancan@huawei.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
James Clark <james.clark@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v1 01/18] gen_compile_commands: Allow the line prefix to still be cmd_
Date: Thu, 28 Sep 2023 16:23:21 +0200 [thread overview]
Message-ID: <ZRWMWcNKvZMgiAMR@bergen.fjasle.eu> (raw)
In-Reply-To: <CAP-5=fV6c1tWAd2GjMwn4PQN=3BXNQGz=vbonHSjRjQ3fbEL+g@mail.gmail.com>
On Mon, 25 Sep 2023 09:06:11 -0700, Ian Rogers wrote:
> On Mon, Sep 25, 2023 at 8:49 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > On Fri, Sep 22, 2023 at 10:35 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > Builds in tools still use the cmd_ prefix in .cmd files, so don't
> > > require the saved part. Name the groups in the line pattern match so
> >
> > Is that something that can be changed in the tools/ Makefiles?
> >
> > I'm fine with this change, just curious where the difference comes
> > from precisely.
> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> I agree. The savedcmd_ change came from Masahiro in:
> https://lore.kernel.org/lkml/20221229091501.916296-1-masahiroy@kernel.org/
> I was reluctant to change the build logic in tools/ because of the
> potential to break things. Maybe Masahiro/Nicolas know of issues?
I haven't seen any issues related to the introduction of savedcmd_; and
roughly searching through tools/ I cannot find a rule that matches the
pattern Masahiro described in commit 92215e7a801d ("kbuild: rename
cmd_$@ to savedcmd_$@ in *.cmd files", 2022-12-29). For consistency,
I'd like to see the build rules in tools/ re-use the ones from scripts/
but as of now I don't see any necessity to introduce savedcmd in
tools/, yet.
Kind regards,
Nicolas
next prev parent reply other threads:[~2023-09-28 14:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 5:34 [PATCH v1 00/18] clang-tools support in tools Ian Rogers
2023-09-23 5:34 ` [PATCH v1 01/18] gen_compile_commands: Allow the line prefix to still be cmd_ Ian Rogers
2023-09-25 15:49 ` Nick Desaulniers
2023-09-25 16:06 ` Ian Rogers
2023-09-28 14:23 ` Nicolas Schier [this message]
2023-10-03 14:31 ` Masahiro Yamada
2023-10-05 22:35 ` Ian Rogers
2023-09-23 5:34 ` [PATCH v1 02/18] gen_compile_commands: Sort output compile commands by file name Ian Rogers
2023-09-25 15:45 ` Nick Desaulniers
2023-09-23 5:35 ` [PATCH v1 03/18] run-clang-tools: Add pass through checks and and header-filter arguments Ian Rogers
2023-09-25 15:43 ` Nick Desaulniers
2023-10-05 22:38 ` Ian Rogers
2023-09-23 5:35 ` [PATCH v1 04/18] perf hisi-ptt: Fix potential memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 05/18] perf bench uprobe: Fix potential use of memory after free Ian Rogers
2023-09-23 5:35 ` [PATCH v1 06/18] perf buildid-cache: Fix use of uninitialized value Ian Rogers
2023-09-23 5:35 ` [PATCH v1 07/18] perf env: Remove unnecessary NULL tests Ian Rogers
2023-09-23 5:35 ` [PATCH v1 08/18] perf jitdump: Avoid memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 09/18] perf mem-events: Avoid uninitialized read Ian Rogers
2023-09-23 5:35 ` [PATCH v1 10/18] perf dlfilter: Be defensive against potential NULL dereference Ian Rogers
2023-09-23 5:35 ` [PATCH v1 11/18] perf hists browser: Reorder variables to reduce padding Ian Rogers
2023-09-23 5:35 ` [PATCH v1 12/18] perf hists browser: Avoid potential NULL dereference Ian Rogers
2023-09-23 5:35 ` [PATCH v1 13/18] perf svghelper: Avoid memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 14/18] perf parse-events: Fix unlikely memory leak when cloning terms Ian Rogers
2023-09-23 5:35 ` [PATCH v1 15/18] tools api: Avoid potential double free Ian Rogers
2023-09-23 5:35 ` [PATCH v1 16/18] perf trace-event-info: Avoid passing NULL value to closedir Ian Rogers
2023-09-23 5:35 ` [PATCH v1 17/18] perf header: Fix various error path memory leaks Ian Rogers
2023-09-23 5:35 ` [PATCH v1 18/18] perf bpf_counter: Fix a few " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRWMWcNKvZMgiAMR@bergen.fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=siyanteng@loongson.cn \
--cc=trix@redhat.com \
--cc=wangming01@loongson.cn \
--cc=yangjihong1@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).