From: Ingo Molnar <mingo@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3] perf doc: Document ring buffer mechanism
Date: Tue, 3 Oct 2023 11:47:57 +0200 [thread overview]
Message-ID: <ZRvjTW4PACGaU2h+@gmail.com> (raw)
In-Reply-To: <ZRvda2QwdFYCp1F1@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
>
> * Leo Yan <leo.yan@linaro.org> wrote:
>
> > In the Linux perf tool, the ring buffer serves not only as a medium for
> > transferring PMU event data but also as a vital mechanism for hardware
> > tracing using technologies like Intel PT and Arm CoreSight, etc.
> >
> > Consequently, the ring buffer mechanism plays a crucial role by ensuring
> > high throughput for data transfer between the kernel and user space
> > while avoiding excessive overhead caused by the ring buffer itself.
> >
> > This commit documents the ring buffer mechanism in detail. It provides
> > an in-depth explanation of the implementation of both the generic ring
> > buffer and the AUX ring buffer. Additionally, it covers how these ring
> > buffers support various tracing modes and explains the synchronization
> > with memory barriers.
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > ---
> >
> > Changes from v2:
> > - Refined doc for Thomas's suggestions (Thomas Richter).
> >
> > Changes from v1:
> > - Addressed Ian's comments and suggestions (Ian Rogers).
> >
> >
> > tools/perf/Documentation/perf-ring-buffer.txt | 762 ++++++++++++++++++
> > 1 file changed, 762 insertions(+)
> > create mode 100644 tools/perf/Documentation/perf-ring-buffer.txt
>
> Nice addition!
>
> If it hasn't been picked up yet:
>
> Acked-by: Ingo Molnar <mingo@kernel.org>
Note that my ack is conditional on the conversion to RST and moving to
Documentation/ - this documents an important aspect of the primary perf
ABI, it deserves to be on the kernel side.
Thanks,
Ingo
next prev parent reply other threads:[~2023-10-03 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:46 [PATCH v3] perf doc: Document ring buffer mechanism Leo Yan
2023-10-03 9:22 ` Ingo Molnar
2023-10-03 9:47 ` Ingo Molnar [this message]
2024-01-06 10:48 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvjTW4PACGaU2h+@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).