From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B824323775 for ; Mon, 16 Oct 2023 11:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SIbae3nI" Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A1A483; Mon, 16 Oct 2023 04:18:18 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9b2f73e3af3so669923966b.3; Mon, 16 Oct 2023 04:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697455097; x=1698059897; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iZ3MOd8AfPXRutQJtnyGXQRK73tC6YBnYLnrIxJBVGo=; b=SIbae3nIe3w1MccVfT37vcctdL68itDb/Aq9azQ6920Pdmq/vz8lK/gMQ4zdbS6NKf r6VNgY2VzMYlHTuCIsMW/RGSnGRpDGU8SweNdBzEDGwUG+cyiS7l8348AEjg7kMutLdx j/5cAofvDOdV0bbyQ3alVB7EXIsJeIxKnZcLFk6knoiYhjsvg9C5fhLJgMnSH0LiOtCB NxQBKXAyN94z/lwQCelcTZzcvsX7c9s9na4oHQ4x12p0kadWoHG/KKKpzCH3n0+yB1R7 AFOIG5SAeWyBk9lvnTL8yX8WyY1NVQ4Y3yIG6p4YAy1xNkhT0vvvGmOI3+mB5NRdc0vf SQjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697455097; x=1698059897; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iZ3MOd8AfPXRutQJtnyGXQRK73tC6YBnYLnrIxJBVGo=; b=QicPvDQLqjx2FilsDXaT5yxR8ZturRYpvGiQcASxRLxLQ3htHnIBDjCwVu791O2BY/ 9Qz4t8ibOvU7y14iWmcjtkJ5v0U5h8tMb3mMEtV2c4Vkl2a3RVMMaaCM3Sn6lEiIgNfg bVY/x3s1SpVO6Pchk/APCIRKIdcW4a4B6MKio/rrtBz/EZZwwhCTIe809X1MlueZYprG QOMIjx42A804RVm/+g8BOreTNEo8j+B7+aoc7okz8ZX6M9W4TNjc/R2wOKZ9QvDR/4bO S5ojmfXNxMw8pCF/XEFErfiHirLVgNpYf9PAvV7hu45IrxjEkLRDcpJOSWcOak80h+7A 7WXA== X-Gm-Message-State: AOJu0YwPeL6SarUIAF7f44tpcruU6+kF+TRcr3+6SuWK8Oy7HzOy/BJ0 KLWDA1feSo61RPlqspdpN+I= X-Google-Smtp-Source: AGHT+IHctV7CbNl5MzddeR1WSsnu6gsJRhRP5ulhdx9tNwTzWvroiApj3re5aYj3fINMGxZL7uqbEw== X-Received: by 2002:a17:907:3d93:b0:9bf:7e40:17b2 with SMTP id he19-20020a1709073d9300b009bf7e4017b2mr4811857ejc.59.1697455096840; Mon, 16 Oct 2023 04:18:16 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id c16-20020a17090620d000b009ae587ce128sm3795766ejc.216.2023.10.16.04.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 04:18:16 -0700 (PDT) Sender: Ingo Molnar Date: Mon, 16 Oct 2023 13:18:13 +0200 From: Ingo Molnar To: Dan Carpenter Cc: Uros Bizjak , Sandipan Das , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] perf/x86/amd/uncore: fix error codes in amd_uncore_init() Message-ID: References: <0c973a20-e10c-4989-b7d9-86cb0f522718@kadam.mountain> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net * Dan Carpenter wrote: > The surprising thing is the Clang doesn't detect the bug either. It's > strange. (I found this bug with Smatch). Yeah, that's weird and kind of concerning. I don't think either compiler is able to see that the init function return values are always ignored. I had to dig into init/main.c to convince myself. > Also I notice that my Fixes tag wasn't correct either. That patch did > have a missing error code bug, but "ret" was set to zero. :/ Yeah, so I left the Fixes tag out of the commit anyway, because this isn't really a fix that -stable should concern itself with. After the first commit it's not even a fix per se, but an improvement in the resolution & meaning of error codes or so. Thanks, Ingo