From: Oliver Upton <oliver.upton@linux.dev>
To: Mark Brown <broonie@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
kvm@vger.kernel.org, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org,
Jing Zhang <jingzhangos@google.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 1/5] tools headers arm64: Copy sysreg-defs generation from kernel source
Date: Wed, 11 Oct 2023 18:05:11 +0000 [thread overview]
Message-ID: <ZSbj16o2FYOTn9DL@linux.dev> (raw)
In-Reply-To: <cef524b7-ecbc-44c4-a582-e39f495c53db@sirena.org.uk>
On Wed, Oct 11, 2023 at 05:59:28PM +0100, Mark Brown wrote:
> On Wed, Oct 11, 2023 at 05:51:57PM +0100, Marc Zyngier wrote:
> > Oliver Upton <oliver.upton@linux.dev> wrote:
>
> > > The system register definitions are now generated with a script over in
> > > the kernel sources. Pull a copy into tools in anticipation of updating
> > > dependent header files and add a common makefile for generating the
> > > header.
>
> > Rather than a copy, which makes the maintenance pretty horrible, why
> > don't you just symlink it? Git is perfectly capable of storing them,
> > last time I checked.
>
> Do we even need to symlink - as I suggested on the previous version can
> we not just reference the script and data file directly in the main
> kernel tree? Like I said then there may be some use case for building
> the tools directory outside the kernel source that I'm not aware of but
> otherwise I'm not clear that the motivations for copying the actual
> headers for use in tools/ apply to these files.
>
> I think the current approach is *fine* (hence my reviewed by)
> given the amount of other copying but it would save a bit of work to not
> copy.
So long as we aren't going to do any further renames I don't have an
issue with this approach.
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-10-11 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 1:10 [PATCH v2 0/5] KVM: selftests: Add ID reg test, update headers Oliver Upton
2023-10-10 1:10 ` [PATCH v2 1/5] tools headers arm64: Copy sysreg-defs generation from kernel source Oliver Upton
2023-10-10 17:50 ` Mark Brown
2023-10-11 16:51 ` Marc Zyngier
2023-10-11 16:59 ` Mark Brown
2023-10-11 18:05 ` Oliver Upton [this message]
2023-10-11 18:13 ` Mark Brown
2023-10-10 1:10 ` [PATCH v2 2/5] perf build: Generate arm64's sysreg-defs.h and add to include path Oliver Upton
2023-10-10 1:10 ` [PATCH v2 3/5] KVM: selftests: Generate " Oliver Upton
2023-10-10 17:53 ` Mark Brown
2023-10-10 1:10 ` [PATCH v2 4/5] tools headers arm64: Update sysreg.h with kernel sources Oliver Upton
2023-10-10 1:10 ` [PATCH v2 5/5] KVM: arm64: selftests: Test for setting ID register from usersapce Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSbj16o2FYOTn9DL@linux.dev \
--to=oliver.upton@linux.dev \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=irogers@google.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=jolsa@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).