From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A60933994A for ; Wed, 11 Oct 2023 18:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QsEW8oO5" Received: from out-190.mta0.migadu.com (out-190.mta0.migadu.com [IPv6:2001:41d0:1004:224b::be]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35ECDA9 for ; Wed, 11 Oct 2023 11:05:20 -0700 (PDT) Date: Wed, 11 Oct 2023 18:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697047518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRTgX+Dt/2jA3rPcRQK47Ac8WI7XuDHgVx6Sck8TIV4=; b=QsEW8oO59znRSH20Z881Su3EwC+j9t1fxQ/8bITL/6ii3NQdDjbGFM+T82lhR0HavTkHqX A4yjoj0FEpN7RZq+qlYv68ucpDOURHnpLcpTTMnuTNdNPsOsHkeeEesaSrF2r7TGZMEEXQ dLo9uawYW2yW7zaY2UGkQYfi3psRujo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Mark Brown Cc: Marc Zyngier , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v2 1/5] tools headers arm64: Copy sysreg-defs generation from kernel source Message-ID: References: <20231010011023.2497088-1-oliver.upton@linux.dev> <20231010011023.2497088-2-oliver.upton@linux.dev> <871qe1m79u.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Oct 11, 2023 at 05:59:28PM +0100, Mark Brown wrote: > On Wed, Oct 11, 2023 at 05:51:57PM +0100, Marc Zyngier wrote: > > Oliver Upton wrote: > > > > The system register definitions are now generated with a script over in > > > the kernel sources. Pull a copy into tools in anticipation of updating > > > dependent header files and add a common makefile for generating the > > > header. > > > Rather than a copy, which makes the maintenance pretty horrible, why > > don't you just symlink it? Git is perfectly capable of storing them, > > last time I checked. > > Do we even need to symlink - as I suggested on the previous version can > we not just reference the script and data file directly in the main > kernel tree? Like I said then there may be some use case for building > the tools directory outside the kernel source that I'm not aware of but > otherwise I'm not clear that the motivations for copying the actual > headers for use in tools/ apply to these files. > > I think the current approach is *fine* (hence my reviewed by) > given the amount of other copying but it would save a bit of work to not > copy. So long as we aren't going to do any further renames I don't have an issue with this approach. -- Thanks, Oliver