From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597302DF96 for ; Thu, 26 Oct 2023 13:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lEAHPGOg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F6E4C433C7; Thu, 26 Oct 2023 13:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698327892; bh=6OD94wbO0wIznaV3pfmqjwHOEwKHbWFYcAgoTrJBlRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lEAHPGOg8i0HQUfm2Lgj228UggRz4lQMNtHQDK3TS4ckSAxnUnSvKfbmJkOqCnBKg ciPVbPH3c3i3zhj68S+8ss6cvxwVC03WPLlwpDPT+uQ1xHLqRdhuLZO9fL3cJPTlZ+ oM4aeCsCFe/hheQOTCmVNORieUj55fG0cXJeCgL19WUFPJEYVEFckRlrAn3xFEto12 em3dJqGlS8/bF0/j32PMZ4DJJWDKMtjDlnVza1bFiY/q3/H2zoSBC2Q8qGzUzj3beF DxMnmjMDzeK9IpwfHVijE/xJcnToWbaAXTwkz7u8zowUrBRG6GBJh6tM/eJ5ybLsgb C9SBA0/w96NYw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 02DEC4035D; Thu, 26 Oct 2023 10:44:49 -0300 (-03) Date: Thu, 26 Oct 2023 10:44:49 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/5] perf tools: Add get_unaligned_leNN() Message-ID: References: <20231005190451.175568-1-adrian.hunter@intel.com> <20231005190451.175568-2-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Em Thu, Oct 05, 2023 at 04:38:05PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Oct 05, 2023 at 10:04:47PM +0300, Adrian Hunter escreveu: > > Add get_unaligned_le16(), get_unaligned_le32 and get_unaligned_le64, same > > as include/asm-generic/unaligned.h. > > > > Use diagnostic pragmas to ignore -Wpacked used by perf build. > > Can we get the tools copy of include/asm-generic/unaligned.h closer and > have it in check-headers.sh? And this is not building when cross building to mips, mips64 and mipsel on debian:experimental: In file included from util/intel-pt-decoder/intel-pt-pkt-decoder.c:10: /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le16': /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:29: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] 13 | const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ | ^ /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:27:28: note: in expansion of macro '__get_unaligned_t' 27 | return le16_to_cpu(__get_unaligned_t(__le16, p)); | ^~~~~~~~~~~~~~~~~ /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le32': /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:29: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] 13 | const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ | ^ /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:32:28: note: in expansion of macro '__get_unaligned_t' 32 | return le32_to_cpu(__get_unaligned_t(__le32, p)); | ^~~~~~~~~~~~~~~~~ Ditto for some other distros when cross building on ubuntu:18.04 MKDIR /tmp/build/perf/util/perf-regs-arch/ In file included from /usr/sparc64-linux-gnu/include/bits/byteswap.h:34:0, from /usr/sparc64-linux-gnu/include/endian.h:60, from util/intel-pt-decoder/intel-pt-pkt-decoder.c:9: /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le16': /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:22: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ ^ /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:27:21: note: in expansion of macro '__get_unaligned_t' return le16_to_cpu(__get_unaligned_t(__le16, p)); ^~~~~~~~~~~~~~~~~ 37 14.17 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 38 13.56 ubuntu:18.04-x-arm64 : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 42 12.70 ubuntu:18.04-x-riscv64 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) 44 13.95 ubuntu:18.04-x-sh4 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) 45 13.08 ubuntu:18.04-x-sparc64 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) > - Arnaldo > > > Signed-off-by: Adrian Hunter > > --- > > tools/include/asm-generic/unaligned.h | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/tools/include/asm-generic/unaligned.h b/tools/include/asm-generic/unaligned.h > > index 47387c607035..9140bb4e16c6 100644 > > --- a/tools/include/asm-generic/unaligned.h > > +++ b/tools/include/asm-generic/unaligned.h > > @@ -6,6 +6,9 @@ > > #ifndef __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H > > #define __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H > > > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Wpacked" > > + > > #define __get_unaligned_t(type, ptr) ({ \ > > const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ > > __pptr->x; \ > > @@ -19,5 +22,22 @@ > > #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr)) > > #define put_unaligned(val, ptr) __put_unaligned_t(typeof(*(ptr)), (val), (ptr)) > > > > +static inline u16 get_unaligned_le16(const void *p) > > +{ > > + return le16_to_cpu(__get_unaligned_t(__le16, p)); > > +} > > + > > +static inline u32 get_unaligned_le32(const void *p) > > +{ > > + return le32_to_cpu(__get_unaligned_t(__le32, p)); > > +} > > + > > +static inline u64 get_unaligned_le64(const void *p) > > +{ > > + return le64_to_cpu(__get_unaligned_t(__le64, p)); > > +} > > + > > +#pragma GCC diagnostic pop > > + > > #endif /* __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H */ > > > > -- > > 2.34.1 > > > > -- > > - Arnaldo -- - Arnaldo